Review main Merged

77320[BUGFIX] Concatenate inline JavaScript with line break

Jonas Eberle CR +2 V +2 Easy +29 −6 updated 11/06/23, 07:33

Commit message

This adds a line break between concatenated "inline" JavaScripts
in order to keep JavaScript without trailing ';' valid.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Jonas Eberle +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jonas Eberle +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1721

  1. Jonas Eberle uploaded patch set 1 01/10/23, 15:29

  2. core-ci voted on patch set 1 V +1 01/10/23, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35654

  3. Georg Ringer commented on patch set 1 03/29/23, 07:17

    is v11 not affected?
  4. Benni Mack commented on patch set 1 03/29/23, 07:26

    ContentObjectRenderer.php:599

    how about we return the cObjects as array? I mean, that'd be cool for any possible further JSON-output?
  5. Benni Mack updated the commit message in patch set 2 V +1 05/03/23, 09:56

  6. Simon Schaufelberger uploaded patch set 3 08/14/23, 04:49

  7. Simon Schaufelberger commented on patch set 3 V +1 CR +1 08/14/23, 04:51

    ContentObjectRenderer.php:599 Reply

    Done
  8. Simon Schaufelberger updated the commit message in patch set 4 CR +1 V +1 08/14/23, 04:53

  9. Simon Schaufelberger voted on patch set 4 V +1 CR +1 08/14/23, 04:53

  10. core-ci voted on patch set 3 V +1 08/14/23, 04:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45462

  11. core-ci voted on patch set 4 V +1 08/14/23, 05:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45463

  12. Oliver Klee commented on patch set 4 08/14/23, 08:29

    ContentObjectRenderer.php:576

    `@return list<string>`
  13. Simon Schaufelberger uploaded patch set 5 CR +1 V +1 08/15/23, 15:17

  14. Simon Schaufelberger commented on patch set 4 V +1 CR +1 08/15/23, 15:17

    ContentObjectRenderer.php:576 Reply

    Done
  15. Simon Schaufelberger voted on patch set 5 V +1 CR +1 08/15/23, 15:18

  16. core-ci voted on patch set 5 V +1 08/15/23, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45509

  17. Jonas Eberle voted on patch set 5 V +1 CR +1 11/04/23, 09:20

  18. Oliver Klee voted on patch set 5 CR +1 11/04/23, 17:22

  19. Benjamin Franzke voted on patch set 5 V +1 CR +1 11/06/23, 05:36

  20. Benjamin Franzke voted on patch set 5 V +2 CR +2 11/06/23, 06:24

  21. Benjamin Franzke merged patch set 6 11/06/23, 07:33