77321[BUGFIX] Normalize Windows file path in CompositeExpression
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1518
-
Robert Kärner uploaded patch set 1 01/10/23, 20:12
-
Stefan Bürk commented on patch set 1 01/10/23, 20:15
-
Robert Kärner commented on patch set 1 01/10/23, 20:17
CompositeExpression.php:99ReplyAck, good point. I didn't notice this line yet. -
Robert Kärner uploaded patch set 2 01/10/23, 20:19
-
core-ci voted on patch set 1 V +1 01/10/23, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35657
-
Robert Kärner commented on patch set 2 01/10/23, 20:21
CompositeExpression.php:99ReplyDone -
Stefan Bürk commented on patch set 2 01/10/23, 20:23
CompositeExpression.php:70Instead of the replace here, I would suggest to use `GeneralUtility::fixWindowsFilePath()` here - what do you think ?CompositeExpression.php:100the path backslash/slash replacement (windows path sanatizing) should be done here too. ( `GeneralUtility::fixWindowsFilePath()` ). Same as above. -
Stefan Bürk commented on patch set 2 01/10/23, 20:26
CompositeExpression.php:70ReplyNot sure if we should do that for the check against __FILE__ to (do not have a windows system since over 2 decades). Eventually for $callingFile generally and for __FILE__ in the check .. but not sure here. -
core-ci voted on patch set 2 V +1 01/10/23, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35658
-
Robert Kärner commented on patch set 2 01/10/23, 20:28
CompositeExpression.php:70ReplyArgh, I knew there was a function for that somewhere. I tried looking in PathUtility and searched for str_replace('\ but no luck. I agree, that's much better.CompositeExpression.php:100ReplyRookie mistake. It's probably too late. Will push a new patchset tomorrow morning when my brain is in working condition again. -
Stefan Bürk uploaded patch set 3
V +101/11/23, 14:16 -
Stefan Bürk commented on patch set 3 01/11/23, 14:17
CompositeExpression.php:70ReplyDoneCompositeExpression.php:100ReplyDone -
core-ci voted on patch set 3 V +1 01/11/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35688
-
Stefan Bürk voted on patch set 3 V +1 CR +1 01/12/23, 12:14
-
Robert Kärner commented on patch set 3 01/12/23, 13:32
I cannot vote, but I have verified that it's working on my instance. Code also looks good to me. -
Oli Bartsch voted on patch set 3 V +1 CR +1 01/12/23, 13:49
-
Stefan Bürk voted on patch set 3 V +2 CR +2 01/12/23, 18:40
-
Stefan Bürk merged patch set 4 01/12/23, 18:40
CompositeExpression.php:99