Review main Merged

77327[TASK] Enhance CKEditor5 alignment plugin handling

Benjamin Kott CR +2 V +2 Hard +410 −0 updated 01/19/23, 23:56

Commit message

This patch ensures that the alignment plugin is
correctly removed, this includes the plugin itself
and the toolbar items. An additional plugin map of
"justify" to "Alignment" ensures that existing
configurations are respected as well.

If the "justify" Plugin is configured to be removed,
it will now remove the "Alignment" plugin that is a
replacement.

We are also adding a migration for "justifyClasses"
to avoid CKEditor using inline styles for existing
configurations.

If no configuration is provided a default configuration
is created.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Benjamin Kott uploaded patch set 1 01/11/23, 09:37

  2. core-ci voted on patch set 1 V -1 01/11/23, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35673

  3. Benjamin Kott uploaded patch set 2 V -1 01/11/23, 11:44

  4. core-ci voted on patch set 2 V -1 01/11/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35678

  5. Benjamin Kott uploaded patch set 3 V -1 01/19/23, 13:41

  6. core-ci voted on patch set 3 V +1 01/19/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36248

  7. Benni Mack voted on patch set 3 CR +1 01/19/23, 13:52

  8. Benni Mack voted on patch set 3 V +1 01/19/23, 14:40

  9. Stefan Bürk voted on patch set 3 V +2 CR +2 01/19/23, 23:56

  10. Stefan Bürk merged patch set 4 01/19/23, 23:56