Review 11.5 Merged

77335[BUGFIX] Harden type annotations around user authentication handling

Benni Mack CR +2 V +2 Easy +3 −3 updated 01/16/23, 13:47

Commit message

When authenticating and fetching user records, appropriate methods
normally pass around either the full database record or `false` in case
the user does not exist or could not be authenticated. The expected
types are now added to all relevant methods in authentication services.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack commented on patch set 1 01/16/23, 12:20

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/16/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35847

  3. Oliver Klee voted on patch set 1 V +1 CR +1 01/16/23, 13:26

  4. Benni Mack voted on patch set 1 V +2 CR +2 01/16/23, 13:47

  5. Benni Mack merged patch set 2 01/16/23, 13:47