77358[BUGFIX] Cover all CKEditor4 toolbar configurations in migration
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 1
Files 3
Review log 2334
Show 59 earlier messages
-
Benjamin Kott uploaded patch set 1 01/11/23, 16:07
-
core-ci voted on patch set 1 V -1 01/11/23, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35702
-
Benjamin Kott uploaded patch set 2
V -101/12/23, 07:39 -
core-ci voted on patch set 2 V -1 01/12/23, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35715
-
Benjamin Kott uploaded patch set 3
V -101/12/23, 15:06 -
core-ci voted on patch set 3 V -1 01/12/23, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35728
-
Benjamin Kott uploaded patch set 4
V -101/13/23, 08:21 -
core-ci voted on patch set 4 V -1 01/13/23, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35744
-
Andreas Kienast commented on patch set 4 01/13/23, 09:05
CKEditor5Migrator.php:137nitpick: combine both unset() calls into a single invocationCKEditor5Migrator.php:447$this->configuration['wordCount']['displayCharacters'] ?? trueCKEditor5Migrator.php:448$this->configuration['wordCount']['displayWords'] ?? true
-
Frank Nägler commented on patch set 4 CR -1 01/13/23, 09:10
CKEditor5MigratorTest.php:179- === | , Benji will check that -
Benjamin Kott uploaded patch set 5
CR -1V -101/13/23, 09:13 -
Benjamin Kott uploaded patch set 6 01/13/23, 09:14
-
Benjamin Kott uploaded patch set 7 01/13/23, 09:17
-
Benjamin Kott commented on patch set 4 01/13/23, 09:17
CKEditor5Migrator.php:133ReplyDoneCKEditor5Migrator.php:137ReplyDoneCKEditor5Migrator.php:447ReplyDoneCKEditor5Migrator.php:448ReplyDone -
Benjamin Kott commented on patch set 7 01/13/23, 09:17
CKEditor5MigratorTest.php:179ReplyDone -
Frank Nägler voted on patch set 7 V +1 CR +1 01/13/23, 09:22
-
core-ci voted on patch set 5 V -1 01/13/23, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35748
-
core-ci voted on patch set 7 V -1 01/13/23, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35750
-
core-ci voted on patch set 6 V -1 01/13/23, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35749
-
Benjamin Kott uploaded patch set 8
CR +1V +101/16/23, 11:13 -
core-ci voted on patch set 8 V -1 01/16/23, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35846
-
Benjamin Kott uploaded patch set 9
V -101/16/23, 12:50 -
core-ci voted on patch set 9 V +1 01/16/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35848
-
Benjamin Kott uploaded patch set 10
V +101/16/23, 15:18 -
core-ci voted on patch set 10 V +1 01/16/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35857
-
Josef Glatz commented on patch set 10 01/17/23, 09:05
Benji, can you explain how this patch can be tested the easiest way? I also wonder if I should test it against real world scenarios?! -
Benjamin Kott commented on patch set 10 01/17/23, 09:37
Reply
- load CKEditor4 toolbar definitions from core (full, minimal, default) - load Bootstrap Package toolbar definitions - load CKEditor5 toolbar definitions from core (full, minimal, default) - Custom Config https://ckeditor.com/latest/samples/toolbarconfigurator/index.html & https://ckeditor.com/docs/ckeditor4/latest/features/toolbarconcepts.html#item-by-item-configuration Remember not all buttons can be migrated, some are just dropped See BUTTON_MAP in CKEditor5Migrator In general all cases are covered in the tests. -
Benni Mack voted on patch set 10 V +1 CR +1 01/17/23, 13:43
-
Andreas Kienast commented on patch set 10 CR -1 01/17/23, 14:58
on it -
Andreas Kienast uploaded patch set 11
CR +1V +101/17/23, 15:04 -
Andreas Kienast voted on patch set 11 CR +1 01/17/23, 15:04
-
core-ci voted on patch set 11 V +1 01/17/23, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35973
-
Benni Mack voted on patch set 11 V +2 CR +2 01/17/23, 15:22
-
Benni Mack merged patch set 12 01/17/23, 15:22
CKEditor5Migrator.php:133