Review main Merged

77359[TASK] Deprecate type="none" "pass_content"

Christian Kuhn CR +2 V +2 Normal +117 −2 updated 01/12/23, 14:51

Commit message

The "pass_content" flag for TCA type="none" is
a potential security risk and should be removed.

A bug in the implementation did not surface the
security risk until now, but instead of fixing the
bug, we deprecate this toggle entirely since the
toggle had no effect for a long time anyways.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1417

  1. Christian Kuhn uploaded patch set 1 01/11/23, 16:44

  2. core-ci voted on patch set 1 V +1 01/11/23, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35703

  3. Oli Bartsch commented on patch set 1 01/11/23, 17:02

    NoneElement.php:58

    I suggest to add a TcaMigration for the config.
  4. Christian Kuhn commented on patch set 1 01/11/23, 17:04

    NoneElement.php:58 Reply

    how? what to migrate?
  5. Christian Kuhn commented on patch set 1 01/11/23, 17:05

    NoneElement.php:58 Reply

    or do you mean a migrator that just scans and logs a usage without changing anything?
  6. Oli Bartsch commented on patch set 1 01/12/23, 08:07

    NoneElement.php:58 Reply

    A TCA migration that removes the option and reports the usage. See for example the removeAuthModeEnforce() or removeAlwaysDescription() methods.
  7. Christian Kuhn commented on patch set 1 CR -1 01/12/23, 08:55

    ok, will give it further thoughts and maybe have a pre-patch again.
  8. Christian Kuhn uploaded patch set 2 CR -1 V +1 01/12/23, 14:23

  9. Christian Kuhn commented on patch set 1 CR -1 01/12/23, 14:23

    NoneElement.php:58 Reply

    Done
  10. core-ci voted on patch set 2 V +1 01/12/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35726

  11. Oli Bartsch commented on patch set 2 CR -1 01/12/23, 14:37

    On it
  12. Oli Bartsch uploaded patch set 3 CR -1 V +1 01/12/23, 14:43

  13. Oli Bartsch voted on patch set 3 V +1 CR +1 01/12/23, 14:43

  14. Benni Mack voted on patch set 3 V +1 CR +1 01/12/23, 14:48

  15. core-ci voted on patch set 3 V +1 01/12/23, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35727

  16. Christian Kuhn voted on patch set 3 V +2 CR +2 01/12/23, 14:51

  17. Christian Kuhn merged patch set 4 01/12/23, 14:51