Review main Merged

77361[BUGFIX] JsonView creates array for ObjectStorage

Markus Klein CR +2 V +2 Easy +5 −0 updated 02/03/23, 15:21

Commit message

The ObjectStorage internals return strings as keys for the elements,
when iterating over the storage.

Users expect JSON arrays (not objects) when rendering an ObjectStorage
through a JsonView.

The `toArray` method takes care of this key conversion.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Markus Klein uploaded patch set 1 01/11/23, 22:15

  2. Markus Klein updated the commit message in patch set 2 01/11/23, 22:17

  3. core-ci voted on patch set 1 V +1 01/11/23, 22:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35707

  4. core-ci voted on patch set 2 V +1 01/11/23, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35708

  5. Simon Schaufelberger voted on patch set 2 CR +1 01/12/23, 03:04

  6. Oliver Klee voted on patch set 2 CR +1 01/12/23, 20:04

  7. Georg Ringer voted on patch set 2 CR +1 02/03/23, 12:01

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 02/03/23, 15:17

  9. Stefan Bürk voted on patch set 2 V +1 02/03/23, 15:21

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 02/03/23, 15:21

  11. Stefan Bürk merged patch set 3 02/03/23, 15:21