Review main Abandoned

77370[BUGFIX] Avoid usage of transform VH in EXT:reports

Georg Ringer CR 0 V 0 Easy +1 −1 updated 07/10/24, 19:11

Commit message

Using f:format.raw instead of f:transform.html fixes exceptions which
derive from having e.g. no site configuration but trying to generate
urls.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 01/13/23, 08:28

  2. Georg Ringer commented on patch set 1 01/13/23, 08:29

    This change is ready for review.
  3. Georg Ringer updated the commit message in patch set 2 01/13/23, 08:33

  4. core-ci voted on patch set 1 V +1 01/13/23, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35745

  5. core-ci voted on patch set 2 V +1 01/13/23, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35746

  6. Josef Glatz commented on patch set 2 V +1 CR +1 01/13/23, 10:18

    +1/+1 after understanding related patch #95713
  7. Oliver Hader commented on patch set 2 CR -1 01/13/23, 10:21

    This might happen anywhere else as well, not just in the report module, correct?
  8. Georg Ringer commented on patch set 2 01/13/23, 11:10

    Reply

    yes. or what having a data-attribute to skip the link transformation in the HtmlWorker?
  9. Josef Glatz commented on patch set 2 01/13/23, 11:14

  10. Oliver Hader commented on patch set 2 01/13/23, 16:15

    → alternative approach https://review.typo3.org/c/Packages/TYPO3.CMS/+/77379 (I did not check all occurrences, however the problem is link generation in backend without having a valid `Site` - `f:format.raw` and similar is not a solution)
  11. Oliver Klee commented on patch set 2 10/08/23, 13:44

    How should we proceed here?
  12. Georg Ringer abandoned the change 07/10/24, 19:11

    solved in 13, issue closed, closing here as well