77370[BUGFIX] Avoid usage of transform VH in EXT:reports
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 1
Review log 1012
-
Georg Ringer uploaded patch set 1 01/13/23, 08:28
-
Georg Ringer commented on patch set 1 01/13/23, 08:29
This change is ready for review. -
Georg Ringer updated the commit message in patch set 2 01/13/23, 08:33
-
core-ci voted on patch set 1 V +1 01/13/23, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35745
-
core-ci voted on patch set 2 V +1 01/13/23, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35746
-
Josef Glatz commented on patch set 2 V +1 CR +1 01/13/23, 10:18
+1/+1 after understanding related patch #95713 -
Oliver Hader commented on patch set 2 CR -1 01/13/23, 10:21
This might happen anywhere else as well, not just in the report module, correct? -
Georg Ringer commented on patch set 2 01/13/23, 11:10
Reply
yes. or what having a data-attribute to skip the link transformation in the HtmlWorker? -
Josef Glatz commented on patch set 2 01/13/23, 11:14
Reply
do you mean f:format.html()? if yes, then I found it just in https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Resources/Private/Partials/Login/LoginNews.html#L45 -
Oliver Hader commented on patch set 2 01/13/23, 16:15
→ alternative approach https://review.typo3.org/c/Packages/TYPO3.CMS/+/77379 (I did not check all occurrences, however the problem is link generation in backend without having a valid `Site` - `f:format.raw` and similar is not a solution) -
Oliver Klee commented on patch set 2 10/08/23, 13:44
How should we proceed here? -
Georg Ringer abandoned the change 07/10/24, 19:11
solved in 13, issue closed, closing here as well