77375[FEATURE] Automatic language key handling with regions (ISO 3166-1)
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Localization/Locales.php7+51 −14
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-86913-AutomaticSupportForLanguageFilesOfLanguagesWithRegionSuffix.rst5new+53 −0
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+53 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php4+4 −4
Review log 3047
Show 1122 earlier messages
-
Benni Mack uploaded patch set 1 01/13/23, 11:43
-
core-ci voted on patch set 1 V -1 01/13/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35759
-
Benni Mack uploaded patch set 2
V -101/13/23, 13:04 -
core-ci voted on patch set 2 V +1 01/13/23, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35764
-
Benni Mack commented on patch set 3
V +101/14/23, 20:07Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 01/14/23, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35802
-
Benni Mack commented on patch set 4
V -101/14/23, 20:27Published edit on patch set 3. -
core-ci voted on patch set 4 V -1 01/14/23, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35803
-
Benni Mack rebased onto patch set 5
V -101/16/23, 11:12 -
core-ci voted on patch set 5 V -1 01/16/23, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35845
-
Benni Mack uploaded patch set 6
V -101/16/23, 13:50 -
core-ci voted on patch set 6 V +1 01/16/23, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35852
-
Benni Mack uploaded patch set 7
V +101/17/23, 10:53 -
Benni Mack uploaded patch set 8 01/17/23, 10:55
-
core-ci voted on patch set 7 V +1 01/17/23, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35930
-
core-ci voted on patch set 8 V +1 01/17/23, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35932
-
Benni Mack uploaded patch set 9
V +101/17/23, 11:32 -
Benni Mack updated the commit message in patch set 10 01/17/23, 11:39
-
core-ci voted on patch set 10 V +1 01/17/23, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35941
-
core-ci voted on patch set 9 V +1 01/17/23, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35939
-
Benni Mack commented on patch set 11
V +101/17/23, 12:16Published edit on patch set 10. -
core-ci voted on patch set 11 V +1 01/17/23, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35951
-
Stefan Bürk commented on patch set 11 01/17/23, 12:43
LanguageService.php:100point or exclamation mark at the end ? -> `Configure it!` ? or should it flow to the next comment block ?RichTextElement.php:202`initialized` .. was wrong before ... -
Benni Mack voted on patch set 11 CR -1 01/17/23, 13:02
-
Benni Mack uploaded patch set 12
CR -1V +101/17/23, 13:47 -
core-ci voted on patch set 12 V +1 01/17/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35965
-
Benni Mack commented on patch set 12 01/17/23, 14:10
LanguageService.php:100ReplyDoneRichTextElement.php:202ReplyDone -
Benni Mack uploaded patch set 13
V +101/17/23, 14:12 -
core-ci voted on patch set 13 V +1 01/17/23, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35967
-
Benni Mack commented on patch set 14
V +101/17/23, 15:23Published edit on patch set 13. -
core-ci voted on patch set 14 V +1 01/17/23, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35974
-
Andreas Kienast commented on patch set 13 01/17/23, 15:33
Locales.php:148"this should be defined here"? -
Georg Ringer commented on patch set 14 01/17/23, 15:34
Locales.php:157should we still ship that?Feature-86913-AutomaticSupportForLanguageFilesOfLanguagesWithRegionSuffix.rst:25I would use a more realistic version, what about Spaß vs Spass? as we really got that for swiss variants having everything in german but the ß replaced -
Benni Mack commented on patch set 14 01/17/23, 22:25
Locales.php:148Replyyes, will remove it in the next iteration.Locales.php:157ReplyWe could register it as a common supported language, but I'd rather not do this in this patch?Feature-86913-AutomaticSupportForLanguageFilesOfLanguagesWithRegionSuffix.rst:25ReplyIn Germany "Spaß" and "Spass" are both valid and depends on the authors' style to write. Is there a difference in Switzerland that nothing should be with "ß"? If so, I'm happy to change it. -
Benni Mack updated the commit message in patch set 15
V +101/17/23, 22:26 -
core-ci voted on patch set 15 V +1 01/17/23, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36045
-
Georg Ringer commented on patch set 15 01/18/23, 06:23
Locales.php:148ReplyAckFeature-86913-AutomaticSupportForLanguageFilesOfLanguagesWithRegionSuffix.rst:25Replyyes, switzerland doesn't use an ß at all, and in austria writing "Spass" in school would be an error ;) -
Benni Mack uploaded patch set 16
V +101/24/23, 09:42 -
Andreas Kienast commented on patch set 16 01/24/23, 09:55
Locales.php:279nitpick only: `empty($dependencies)` could be replaced with `$dependencies === []` and checked first as this is "faster" than `str_contains()`.RichTextElement.php:212nitpick: conditions can be swapped -
core-ci voted on patch set 16 V +1 01/24/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36525
-
Andreas Kienast uploaded patch set 17
V +101/24/23, 10:08 -
core-ci voted on patch set 17 V +1 01/24/23, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36528
-
Andreas Kienast commented on patch set 17 CR +1 01/24/23, 10:40
Locales.php:279ReplyDoneRichTextElement.php:212ReplyDone -
Benni Mack commented on patch set 17 01/24/23, 12:54
Feature-86913-AutomaticSupportForLanguageFilesOfLanguagesWithRegionSuffix.rst:25ReplyOK. The most common topic I had with de_DE and de_CH was "Offerte" in the past decade, but the differences between de_AT and de_CH I was unaware of today. Can you update the RST or should we leave it like it is? -
Georg Ringer commented on patch set 17 V +1 CR +1 01/24/23, 13:18
Feature-86913-AutomaticSupportForLanguageFilesOfLanguagesWithRegionSuffix.rst:25ReplyDone -
Benni Mack voted on patch set 17 V +2 CR +2 01/24/23, 13:21
-
Benni Mack merged patch set 18 01/24/23, 13:21