Review main Abandoned

77379[BUGFIX] Avoid creating TSFE instance with NullSite

Oliver Hader CR 0 V 0 Easy +2 −3 updated 01/24/25, 10:25

Commit message

Creating TSFE with a NullSite instance fails. That's why
TSFE is not created at all during URL generation in of
\TYPO3\CMS\Frontend\Typolink\AbstractTypolinkBuilder.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1721

  1. Oliver Hader uploaded patch set 1 01/13/23, 16:14

  2. core-ci voted on patch set 1 V -1 01/13/23, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35770

  3. Oliver Hader uploaded patch set 2 V -1 01/13/23, 16:23

  4. core-ci voted on patch set 2 V +1 01/13/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35771

  5. Oliver Hader commented on patch set 2 02/03/23, 11:04

    Ping
  6. Josef Glatz commented on patch set 2 02/03/23, 11:18

    sorry, can‘t give feedback in this area
  7. Josef Glatz commented on patch set 2 02/03/23, 11:19

    Reply

    I just can test scenarios here „if it works“
  8. Benni Mack commented on patch set 2 04/03/23, 08:49

    Reply Unresolved

    does it work?
  9. Oliver Klee voted on patch set 2 CR +1 04/03/23, 10:37

  10. Oliver Hader updated the commit message in patch set 3 CR +1 V +1 04/03/23, 15:38

  11. Oliver Hader commented on patch set 3 04/03/23, 15:39

    This change was an alternative approach to https://review.typo3.org/c/Packages/TYPO3.CMS/+/77370
  12. Oliver Klee voted on patch set 3 CR +1 04/03/23, 15:39

  13. Oliver Hader updated the commit message in patch set 4 CR +1 04/03/23, 15:39

  14. Oliver Klee voted on patch set 4 CR +1 04/03/23, 15:46

  15. core-ci voted on patch set 3 V -1 04/03/23, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40026

  16. core-ci voted on patch set 4 V -1 04/03/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40027

  17. Oliver Klee voted on patch set 4 CR 0 04/03/23, 16:15

  18. Oliver Klee commented on patch set 4 04/03/23, 16:17

    Unresolved

    I propose mentioning in which scenarios the old code would create a problem (i.e., why we want this change.)
  19. Oliver Klee wrote 04/03/23, 16:34

    Removed reviewer Oliver Klee.
  20. Oliver Hader marked it work in progress 04/03/23, 18:19

  21. Oliver Hader abandoned the change 01/24/25, 10:25