77379[BUGFIX] Avoid creating TSFE instance with NullSite
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1721
-
Oliver Hader uploaded patch set 1 01/13/23, 16:14
-
core-ci voted on patch set 1 V -1 01/13/23, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35770
-
Oliver Hader uploaded patch set 2
V -101/13/23, 16:23 -
core-ci voted on patch set 2 V +1 01/13/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35771
-
Oliver Hader commented on patch set 2 02/03/23, 11:04
Ping -
Josef Glatz commented on patch set 2 02/03/23, 11:18
sorry, can‘t give feedback in this area -
Josef Glatz commented on patch set 2 02/03/23, 11:19
Reply
I just can test scenarios here „if it works“ -
Benni Mack commented on patch set 2 04/03/23, 08:49
Reply Unresolved
does it work? -
Oliver Klee voted on patch set 2 CR +1 04/03/23, 10:37
-
Oliver Hader updated the commit message in patch set 3
CR +1V +104/03/23, 15:38 -
Oliver Hader commented on patch set 3 04/03/23, 15:39
This change was an alternative approach to https://review.typo3.org/c/Packages/TYPO3.CMS/+/77370 -
Oliver Klee voted on patch set 3 CR +1 04/03/23, 15:39
-
Oliver Hader updated the commit message in patch set 4
CR +104/03/23, 15:39 -
Oliver Klee voted on patch set 4 CR +1 04/03/23, 15:46
-
core-ci voted on patch set 3 V -1 04/03/23, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40026
-
core-ci voted on patch set 4 V -1 04/03/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40027
-
Oliver Klee voted on patch set 4 CR 0 04/03/23, 16:15
-
Oliver Klee commented on patch set 4 04/03/23, 16:17
Unresolved
I propose mentioning in which scenarios the old code would create a problem (i.e., why we want this change.) -
Oliver Klee wrote 04/03/23, 16:34
Removed reviewer Oliver Klee. -
Oliver Hader marked it work in progress 04/03/23, 18:19
-
Oliver Hader abandoned the change 01/24/25, 10:25