Review main Abandoned

77381[TASK] Improve color of link in toolbar for the log module

Georg Ringer CR 0 V 0 Easy +1 −1 updated 02/03/23, 09:31

Commit message

Render the link in the toolbar which links to the logging module with
the correct color instead of white.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1620

  1. Georg Ringer uploaded patch set 1 01/13/23, 19:58

  2. Georg Ringer commented on patch set 1 01/13/23, 19:58

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 01/13/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35783

  4. Josef Glatz voted on patch set 1 V +1 CR +1 01/14/23, 08:16

  5. Oli Bartsch commented on patch set 1 01/16/23, 14:04

    _dropdown.scss:115

    I think this does not fit in here, as the file is all about general dropdown styles.
  6. Georg Ringer commented on patch set 1 01/18/23, 06:52

    _dropdown.scss:115 Reply Unresolved

    I know, maybe benji nows a better place/solution, however I really don't like the white link in there ;)
  7. Andreas Kienast commented on patch set 1 V +1 CR -1 01/18/23, 07:33

    The patch itself works, but I dislike the how it's hardcoded to be_syslog. Will check for a better solution.
  8. Andreas Kienast uploaded patch set 2 CR +1 V +1 01/18/23, 07:46

  9. Andreas Kienast commented on patch set 2 01/18/23, 07:48

    I really like to get a review from Benji on this before merging.
  10. core-ci voted on patch set 2 V +1 01/18/23, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36055

  11. Jörg Bösche voted on patch set 2 CR +1 01/20/23, 08:15

  12. Benjamin Kott commented on patch set 2 01/23/23, 10:21

    the patch does not resolve the issue but provides more in different places. if the highlight should change here add a class to that link instead unsetting all link styles in general.
  13. Benjamin Kott voted on patch set 2 V -1 CR -1 01/23/23, 10:21

  14. Georg Ringer uploaded patch set 3 CR +1 V +1 01/23/23, 20:16

  15. Georg Ringer commented on patch set 3 01/23/23, 20:17

    now a different way, however the underline should be added somehow. don't know which the best way isfor that
  16. Christian Kuhn commented on patch set 3 CR -1 01/23/23, 20:23

    SystemInformationController.php:67 Unresolved

    if (true) is obviously useless.
  17. core-ci voted on patch set 3 V -1 01/23/23, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36495

  18. Georg Ringer uploaded patch set 4 CR -1 V -1 01/25/23, 09:26

  19. core-ci voted on patch set 4 V +1 01/25/23, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36601

  20. Georg Ringer abandoned the change 02/03/23, 09:31

    solved now