77381[TASK] Improve color of link in toolbar for the log module
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1620
-
Georg Ringer uploaded patch set 1 01/13/23, 19:58
-
Georg Ringer commented on patch set 1 01/13/23, 19:58
This change is ready for review. -
core-ci voted on patch set 1 V +1 01/13/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35783
-
Josef Glatz voted on patch set 1 V +1 CR +1 01/14/23, 08:16
-
Oli Bartsch commented on patch set 1 01/16/23, 14:04
_dropdown.scss:115I think this does not fit in here, as the file is all about general dropdown styles. -
Georg Ringer commented on patch set 1 01/18/23, 06:52
_dropdown.scss:115Reply UnresolvedI know, maybe benji nows a better place/solution, however I really don't like the white link in there ;) -
Andreas Kienast commented on patch set 1 V +1 CR -1 01/18/23, 07:33
The patch itself works, but I dislike the how it's hardcoded to be_syslog. Will check for a better solution. -
Andreas Kienast uploaded patch set 2
CR +1V +101/18/23, 07:46 -
Andreas Kienast commented on patch set 2 01/18/23, 07:48
I really like to get a review from Benji on this before merging. -
core-ci voted on patch set 2 V +1 01/18/23, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36055
-
Jörg Bösche voted on patch set 2 CR +1 01/20/23, 08:15
-
Benjamin Kott commented on patch set 2 01/23/23, 10:21
the patch does not resolve the issue but provides more in different places. if the highlight should change here add a class to that link instead unsetting all link styles in general. -
Benjamin Kott voted on patch set 2 V -1 CR -1 01/23/23, 10:21
-
Georg Ringer uploaded patch set 3
CR +1V +101/23/23, 20:16 -
Georg Ringer commented on patch set 3 01/23/23, 20:17
now a different way, however the underline should be added somehow. don't know which the best way isfor that -
Christian Kuhn commented on patch set 3 CR -1 01/23/23, 20:23
SystemInformationController.php:67Unresolvedif (true) is obviously useless. -
core-ci voted on patch set 3 V -1 01/23/23, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36495
-
Georg Ringer uploaded patch set 4
CR -1V -101/25/23, 09:26 -
core-ci voted on patch set 4 V +1 01/25/23, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36601
-
Georg Ringer abandoned the change 02/03/23, 09:31
solved now