77383[BUGFIX] Deduplicate slugs with language -1
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php2+20 −4
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/DataSet/TestSlugUniqueWithLanguages.csv2new+6 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/DataSet/TestSlugUniqueWithLanguagesResult.csv2new+4 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperUniqueWithLanguageTest.phpnew+115 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_slug/Configuration/TCA/tx_testdatahandler_slug.phpnew+90 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_slug/ext_emconf.phpnew+19 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_slug/ext_tables.sql2new+6 −0
Review log 1419
-
Sybille Peters uploaded patch set 1 01/14/23, 09:51
-
core-ci voted on patch set 1 V +1 01/14/23, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35794
-
Sybille Peters updated the commit message in patch set 2
V +101/14/23, 10:02 -
core-ci voted on patch set 2 V +1 01/14/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35795
-
Sybille Peters uploaded patch set 3
V +101/14/23, 19:07 -
core-ci voted on patch set 3 V +1 01/14/23, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35799
-
Stefan Bürk commented on patch set 3 CR -1 01/15/23, 16:35
nice catch - just some remarks on unneeded/superflous stuff, thus the -1.SlugHelper.php:472would suggest to add here "language records" or so to make it clear (nitpick)TestSlugUniqueWithLanguages.csv:4superflous emptylineTestSlugUniqueWithLanguagesResult.csv:5superflous emptylineext_tables.sql:5No need to define fields which are auto created: * `uid` (and the primary key for it) - always * `pid` - always * `tstamp` - if `['ctrl']['tstamp']` is set * `crdate` - if `['ctrl']['crdate']` is set * `deleted` - if `['ctrl']['delete']` is set * `hidden` - if `['ctrl']['enablecolumns']['disabled']` is set * `sys_language_uid` - if `['ctrl']['languageField']` is set * `l10n_parent` - if `['ctrl']['languageField']`and `['ctrl']['transOrigPointerField']` is set * `l10n_diff_source` - if `['ctrl']['transOrigDiffSourceField']` is set * `slug` - if `['columns']['fieldName']['config']['type']` is set to `slug` Schema definition for these fields are automatically created by `DefaultTcaSchema` if corresponding TCA definitions are provided. So they *must* omitted here, leaving only `title` to be defined manually. Also, slug must be added on 11.5 backport - auto creation for this field has been added in v12: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75865 -
Stefan Bürk uploaded patch set 4
CR -1V +101/15/23, 16:43 -
core-ci voted on patch set 4 V +1 01/15/23, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35815
-
Stefan Bürk commented on patch set 4 V +1 CR +1 01/15/23, 16:56
Reply
DoneSlugHelper.php:472ReplyDoneTestSlugUniqueWithLanguages.csv:4ReplyDoneTestSlugUniqueWithLanguagesResult.csv:5ReplyDoneext_tables.sql:5ReplyDone -
Oli Bartsch voted on patch set 4 V +1 CR +1 01/16/23, 14:16
-
Stefan Bürk voted on patch set 4 CR -1 01/16/23, 14:16
-
Stefan Bürk commented on patch set 4 01/16/23, 14:17
main, not master -
Stefan Bürk updated the commit message in patch set 5
CR +1V +101/16/23, 14:17 -
Stefan Bürk voted on patch set 5 V +1 CR +1 01/16/23, 14:17
-
Oli Bartsch commented on patch set 5 V +1 CR +1 01/16/23, 14:31
Reply
Ack -
core-ci voted on patch set 5 V +1 01/16/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35855
-
Stefan Bürk commented on patch set 5 V +2 CR +2 01/16/23, 20:26
Reply
Done -
Stefan Bürk merged patch set 6 01/16/23, 20:57