7739[BUGFIX] MENU special = updated does not work anymore
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Oliver Hader +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Xavier Perseguers +2
- Wouter Wolters +1
- Oliver Hader +1
Files 1
Review log 14
-
Oliver Hader commented on patch set 1 V 0 01/18/12, 11:17
by team member; Looks good to me, approved I confirm that the patch works and solves the issue (it's quite obvious). The issue with "not working" might be based on the "maxAge" property and the fact that pages.SYS_LASTCHANGED just does not get updated - so on modifying a page record, SYS_LASTCHANGED stays the same - a different story though. -
Oliver Hader commented on patch set 1 01/18/12, 11:17
Since there has not been any feedback from Wouter and my analyze on the origin of his finding, his -1 got removed. -
Oliver Hader commented on patch set 1 V 0 01/18/12, 11:17
Okay, SYS_LASTCHANGED gets updated if a modified page is rendered in frontend. I think this approach is wrong and here tstamp should be used instead in tslib_menu... -
Oliver Hader commented on patch set 1 01/18/12, 11:17
@Philip: Yepp, but only if the page is rendered, the SYS_LASTCHANGE is updated - if you just modify something of or on that page and don't load it in frontend, it will not be considered as changed... So, the process is/was somehow not optimal at all... -
Xavier Perseguers commented on patch set 1 01/18/12, 11:17
Please provide a step-by-step how to (in the bug tracker) on how to reproduce this issue in 4.7 because current behaviour CANNOT work unless you define your special menu in a TS put on the root of your page tree and you show the menu there. -
Xavier Perseguers commented on patch set 1 V 0 01/18/12, 11:17
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 1 01/18/12, 11:17
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 01/18/12, 11:17
@Oliver doesn't SYS_LASTCHANGED also gets updated on CE change? The timestamp is only updated if you change the page properties ?!? -
Ingo Pfennigstorf commented on patch set 1 01/18/12, 11:17
At least it shows one or two updated pages now but does imho not show all updated pages here. Will investigate on this strange behaviour. I tried it with CE Sitemap -> recently updated -
Mr. Jenkins commented on patch set 1 01/18/12, 11:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2943/ : SUCCESS -
Wouter Wolters commented on patch set 1 01/18/12, 11:17
Verified; Looks good to me, but someone else must approve Thanks Oliver for your explanation. The problem I had was that the page where not rendered in the frontend. Now I tested the patch again and can now confirm that the patch is correct. -
Wouter Wolters commented on patch set 1 01/18/12, 11:17
I hadn't have the time to look into the problem yet. Will test this patch again tonight -
Wouter Wolters commented on patch set 1 01/18/12, 11:17
Fails Without this patch in 4.7 it shows me one updated page (updated 3 pages). With the patch it doesn't show me any updated pages -
Xavier Perseguers merged patch set 1 01/18/12, 11:17