77396[FEATURE] Introduce "Missing Meta Description" widget
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99552-IntroduceMissingMetaDescriptionWidget.rstnew+27 −0
- typo3/sysext/dashboard/Configuration/Backend/DashboardWidgetGroups.php+2 −0
- typo3/sysext/seo/Classes/Widgets/Provider/PagesWithoutDescriptionDataProvider.php4new+103 −0
- typo3/sysext/seo/Classes/Widgets/PagesWithoutDescriptionWidget.phpnew+62 −0
- typo3/sysext/seo/Configuration/Backend/DashboardWidgetGroups.phpnew+9 −0
- typo3/sysext/seo/Configuration/Services.yaml+20 −0
- typo3/sysext/seo/Resources/Private/Language/locallang_dashboard.xlfnew+21 −0
- typo3/sysext/seo/Resources/Private/Templates/Widget/PagesWithoutDescription.htmlnew+41 −0
- typo3/sysext/seo/composer.json+3 −0
Review log 3855
Show 1930 earlier messages
-
Kevin Appelt uploaded patch set 1 01/16/23, 16:20
-
core-ci voted on patch set 1 V -1 01/16/23, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35862
-
Kevin Appelt uploaded patch set 2
V -101/16/23, 16:52 -
core-ci voted on patch set 2 V +1 01/16/23, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35865
-
Nikita Hovratov uploaded patch set 3
V +101/16/23, 19:29 -
core-ci voted on patch set 3 V -1 01/16/23, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35884
-
Nikita Hovratov uploaded patch set 4
V -101/17/23, 11:39 -
Kevin Appelt uploaded patch set 5 01/17/23, 11:45
-
Nikita Hovratov uploaded patch set 6 01/17/23, 11:47
-
Kevin Appelt uploaded patch set 7 01/17/23, 11:54
-
core-ci voted on patch set 5 V +1 01/17/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35944
-
core-ci voted on patch set 4 V -1 01/17/23, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35942
-
core-ci voted on patch set 6 V -1 01/17/23, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35946
-
core-ci voted on patch set 7 V -1 01/17/23, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35948
-
Kevin Appelt uploaded patch set 8
V -101/17/23, 12:57 -
core-ci voted on patch set 8 V +1 01/17/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35958
-
Nikita Hovratov uploaded patch set 9
V +101/17/23, 14:43 -
Nikita Hovratov voted on patch set 9 V +1 CR +1 01/17/23, 14:43
-
core-ci voted on patch set 9 V +1 01/17/23, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35972
-
Christian Kuhn commented on patch set 9 CR -1 01/17/23, 14:51
-
Christian Kuhn commented on patch set 9 01/17/23, 14:54
PagesWithoutDescriptionDataProvider.php:60we may want to comment on 'what's the behavior with localized pages' at least for documentation purposes here. -
Kevin Appelt uploaded patch set 10
CR +1V +101/17/23, 21:06 -
Kevin Appelt commented on patch set 10 01/17/23, 21:07
PageOverviewWidget.php:37ReplyDone -
core-ci voted on patch set 10 V +1 01/17/23, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36032
-
Stefan Bürk commented on patch set 10 01/17/23, 21:28
Services.php:5Should be `TYPO3\CMS\Seo` like for `ext:core` or `ext:frontend` -
Georg Ringer commented on patch set 10 CR -1 01/17/23, 21:31
Services.php:5doesnt look right, also copyright missing -
Stefan Bürk commented on patch set 10 01/17/23, 22:27
Services.php:5Reply> doesnt look right, also copyright missing copyright is normally not included in Configuration folder ... other Configuration/Services.php are missing it either ... and Configuration folder is excluded from header check ... -
Kevin Appelt uploaded patch set 11
CR -1V +101/18/23, 11:44 -
core-ci voted on patch set 11 V +1 01/18/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36077
-
Stefan Bürk commented on patch set 12
V +101/18/23, 11:58Published edit on patch set 11.
-
Kevin Appelt commented on patch set 11 01/18/23, 11:59
Currently still checking the behaviour with workspaces.PagesWithoutDescriptionDataProvider.php:60ReplyDoneServices.php:5ReplySo I won't add a copyright, but I adjusted the namespace.Services.php:5ReplyDone -
Stefan Bürk commented on patch set 12 01/18/23, 11:59
Services.php:5ReplyDoneServices.php:5ReplyDone -
core-ci voted on patch set 12 V +1 01/18/23, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36078
-
Kevin Appelt uploaded patch set 13
V +101/18/23, 12:27 -
Kevin Appelt uploaded patch set 14 01/18/23, 12:28
-
core-ci voted on patch set 14 V +1 01/18/23, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36084
-
core-ci voted on patch set 13 V -1 01/18/23, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36083
-
Stefan Bürk commented on patch set 14 01/18/23, 12:49
PagesWithoutDescriptionDataProvider.php:81Type hints are superflous, method has native types. -
Christian Kuhn commented on patch set 14 CR -1 01/18/23, 13:38
on it. -
Kevin Appelt commented on patch set 14 01/27/23, 06:55
Reply
Any progress on this? Would be great to see this in 12.2 - let me know if you need any kind of support :) -
Christian Kuhn uploaded patch set 15
CR -1V +102/03/23, 10:50 -
Christian Kuhn commented on patch set 14 CR -1 02/03/23, 10:50
PageOverviewWidget.php:30BackendViewFactory instead.PageOverviewWidget.php:37PageProviderInterface.php:20please avoid this interface - at least for now - when there is only one consumer. -
Christian Kuhn commented on patch set 15 02/03/23, 10:50
PagesWithoutDescriptionDataProvider.php:81ReplyDone -
Christian Kuhn commented on patch set 15 02/03/23, 10:50
Reply
Done -
Christian Kuhn voted on patch set 15 CR -1 02/03/23, 10:58
-
core-ci voted on patch set 15 V -1 02/03/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36973
-
Christian Kuhn uploaded patch set 16
CR -1V -102/03/23, 11:21 -
Christian Kuhn uploaded patch set 17 02/03/23, 11:22
-
Christian Kuhn uploaded patch set 18 02/03/23, 11:31
-
core-ci voted on patch set 16 V -1 02/03/23, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36977
-
core-ci voted on patch set 18 V +1 02/03/23, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36980
-
Christian Kuhn commented on patch set 18 V +1 CR +1 02/03/23, 12:18
this looks to me as if we could go with this for now. -
Nikita Hovratov voted on patch set 18 V +1 CR +1 02/03/23, 12:41
-
Christian Kuhn voted on patch set 18 V +2 CR +2 02/03/23, 12:46
-
Christian Kuhn merged patch set 19 02/03/23, 12:46
PageOverviewWidget.php:37