Review main Merged

77396[FEATURE] Introduce "Missing Meta Description" widget

Kevin Appelt CR +2 V +2 Hard +290 −2 updated 02/03/23, 12:46

Commit message

This SEO widget lists pages with missing description
ordered by the last changed date.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 3855

Show 1930 earlier messages
  1. Kevin Appelt uploaded patch set 1 01/16/23, 16:20

  2. core-ci voted on patch set 1 V -1 01/16/23, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35862

  3. Kevin Appelt uploaded patch set 2 V -1 01/16/23, 16:52

  4. core-ci voted on patch set 2 V +1 01/16/23, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35865

  5. Nikita Hovratov uploaded patch set 3 V +1 01/16/23, 19:29

  6. core-ci voted on patch set 3 V -1 01/16/23, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35884

  7. Nikita Hovratov uploaded patch set 4 V -1 01/17/23, 11:39

  8. Kevin Appelt uploaded patch set 5 01/17/23, 11:45

  9. Nikita Hovratov uploaded patch set 6 01/17/23, 11:47

  10. Kevin Appelt uploaded patch set 7 01/17/23, 11:54

  11. core-ci voted on patch set 5 V +1 01/17/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35944

  12. core-ci voted on patch set 4 V -1 01/17/23, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35942

  13. core-ci voted on patch set 6 V -1 01/17/23, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35946

  14. core-ci voted on patch set 7 V -1 01/17/23, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35948

  15. Kevin Appelt uploaded patch set 8 V -1 01/17/23, 12:57

  16. core-ci voted on patch set 8 V +1 01/17/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35958

  17. Nikita Hovratov uploaded patch set 9 V +1 01/17/23, 14:43

  18. Nikita Hovratov voted on patch set 9 V +1 CR +1 01/17/23, 14:43

  19. core-ci voted on patch set 9 V +1 01/17/23, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35972

  20. Christian Kuhn commented on patch set 9 CR -1 01/17/23, 14:51

    PageOverviewWidget.php:37

    avoid method. use ->render(Widget/PageOverviewWidget) to leverage BE template override magic. see other existing widgets.
  21. Christian Kuhn commented on patch set 9 01/17/23, 14:54

    PagesWithoutDescriptionDataProvider.php:60

    we may want to comment on 'what's the behavior with localized pages' at least for documentation purposes here.
  22. Kevin Appelt uploaded patch set 10 CR +1 V +1 01/17/23, 21:06

  23. Kevin Appelt commented on patch set 10 01/17/23, 21:07

    PageOverviewWidget.php:37 Reply

    Done
  24. core-ci voted on patch set 10 V +1 01/17/23, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36032

  25. Stefan Bürk commented on patch set 10 01/17/23, 21:28

    Services.php:5

    Should be `TYPO3\CMS\Seo` like for `ext:core` or `ext:frontend`
  26. Georg Ringer commented on patch set 10 CR -1 01/17/23, 21:31

    Services.php:5

    doesnt look right, also copyright missing
  27. Stefan Bürk commented on patch set 10 01/17/23, 22:27

    Services.php:5 Reply

    > doesnt look right, also copyright missing copyright is normally not included in Configuration folder ... other Configuration/Services.php are missing it either ... and Configuration folder is excluded from header check ...
  28. Kevin Appelt uploaded patch set 11 CR -1 V +1 01/18/23, 11:44

  29. core-ci voted on patch set 11 V +1 01/18/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36077

  30. Stefan Bürk commented on patch set 12 V +1 01/18/23, 11:58

    Published edit on patch set 11.
  1. Kevin Appelt commented on patch set 11 01/18/23, 11:59

    Currently still checking the behaviour with workspaces.

    PagesWithoutDescriptionDataProvider.php:60 Reply

    Done

    Services.php:5 Reply

    So I won't add a copyright, but I adjusted the namespace.

    Services.php:5 Reply

    Done
  2. Stefan Bürk commented on patch set 12 01/18/23, 11:59

    Services.php:5 Reply

    Done

    Services.php:5 Reply

    Done
  3. core-ci voted on patch set 12 V +1 01/18/23, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36078

  4. Kevin Appelt uploaded patch set 13 V +1 01/18/23, 12:27

  5. Kevin Appelt uploaded patch set 14 01/18/23, 12:28

  6. core-ci voted on patch set 14 V +1 01/18/23, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36084

  7. core-ci voted on patch set 13 V -1 01/18/23, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36083

  8. Stefan Bürk commented on patch set 14 01/18/23, 12:49

    PagesWithoutDescriptionDataProvider.php:81

    Type hints are superflous, method has native types.
  9. Christian Kuhn commented on patch set 14 CR -1 01/18/23, 13:38

    on it.
  10. Kevin Appelt commented on patch set 14 01/27/23, 06:55

    Reply

    Any progress on this? Would be great to see this in 12.2 - let me know if you need any kind of support :)
  11. Christian Kuhn uploaded patch set 15 CR -1 V +1 02/03/23, 10:50

  12. Christian Kuhn commented on patch set 14 CR -1 02/03/23, 10:50

    PageOverviewWidget.php:30

    BackendViewFactory instead.

    PageProviderInterface.php:20

    please avoid this interface - at least for now - when there is only one consumer.
  13. Christian Kuhn commented on patch set 15 02/03/23, 10:50

    PagesWithoutDescriptionDataProvider.php:81 Reply

    Done
  14. Christian Kuhn commented on patch set 15 02/03/23, 10:50

    Reply

    Done
  15. Christian Kuhn voted on patch set 15 CR -1 02/03/23, 10:58

  16. core-ci voted on patch set 15 V -1 02/03/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36973

  17. Christian Kuhn uploaded patch set 16 CR -1 V -1 02/03/23, 11:21

  18. Christian Kuhn uploaded patch set 17 02/03/23, 11:22

  19. Christian Kuhn uploaded patch set 18 02/03/23, 11:31

  20. core-ci voted on patch set 16 V -1 02/03/23, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36977

  21. core-ci voted on patch set 18 V +1 02/03/23, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36980

  22. Christian Kuhn commented on patch set 18 V +1 CR +1 02/03/23, 12:18

    this looks to me as if we could go with this for now.
  23. Nikita Hovratov voted on patch set 18 V +1 CR +1 02/03/23, 12:41

  24. Christian Kuhn voted on patch set 18 V +2 CR +2 02/03/23, 12:46

  25. Christian Kuhn merged patch set 19 02/03/23, 12:46