77403[TASK] Migrate EXT:form TranslationServiceTest to functional
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Hader +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 20
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/form/Classes/Service/TranslationService.php+4 −7
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/Resources/Private/Language/de.locallang_form.xlfrenamed+1 −1
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/Resources/Private/Language/de.locallang_text.xlfrenamed+1 −1
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_additional_text.xlfrenamed+0 −0
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_ceuid_suffix_01.xlfrenamed+0 −0
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_ceuid_suffix_02.xlfrenamed+0 −0
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_empty_values.xlfrenamed+0 −0
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_form.xlfrenamed+0 −0
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_text.xlfrenamed+0 −0
- typo3/sysext/form/Tests/Functional/Service/Fixtures/Extensions/form_labels/ext_emconf.phpnew+21 −0
- typo3/sysext/form/Tests/Functional/Service/TranslationServiceTest.phpnew+1177 −0
- typo3/sysext/form/Tests/Unit/Service/Fixtures/de.locallang_form.phpdeleted+0 −28
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_additional_text.phpdeleted+0 −25
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_ceuid_suffix_01.phpdeleted+0 −49
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_ceuid_suffix_02.phpdeleted+0 −89
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_empty_values.phpdeleted+0 −59
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_form.phpdeleted+0 −137
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_text.phpdeleted+0 −105
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.phpdeleted+0 −1430
Review log 1318
-
Benni Mack uploaded patch set 1 01/16/23, 19:02
-
Nikita Hovratov voted on patch set 1 V +1 CR +1 01/16/23, 19:12
-
core-ci voted on patch set 1 V -1 01/16/23, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35878
-
Oliver Hader voted on patch set 1 V +1 CR +1 01/16/23, 19:33
-
Benni Mack uploaded patch set 2
CR +1V +101/16/23, 19:42 -
Oliver Hader voted on patch set 2 V +1 CR +1 01/16/23, 19:56
-
Christian Kuhn voted on patch set 2 V +1 CR +1 01/16/23, 20:01
-
Oliver Hader voted on patch set 2 V +2 CR +2 01/16/23, 20:08
-
Benni Mack uploaded patch set 3
CR +1V +101/16/23, 20:08 -
core-ci voted on patch set 2 V +1 01/16/23, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35890
-
Oliver Hader voted on patch set 3 V +1 CR +1 01/16/23, 20:16
-
core-ci voted on patch set 3 V -1 01/16/23, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35893
-
core-ci commented on patch set 3 01/16/23, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35893
-
Benni Mack uploaded patch set 4
CR +1V +101/17/23, 09:03 -
Oliver Hader voted on patch set 4 V +1 CR +1 01/17/23, 09:04
-
core-ci voted on patch set 4 V +1 01/17/23, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35910
-
Christian Kuhn voted on patch set 4 V +2 CR +2 01/17/23, 09:22
-
Christian Kuhn merged patch set 5 01/17/23, 09:22