Review 11.5 Merged

77407[BUGFIX] Deduplicate slugs with language -1

Stefan Bürk CR +2 V +2 Hard +261 −6 updated 01/16/23, 20:57

Commit message

Checking for duplicate slugs in DataHandler will
now make sure that no two fields with the same
slug exist, where one of them has a language of
-1.

Existing records are not migrated. This could be
done in a followup patch or with a community
extension.

When new records are created or changed which have a
field of type "slug", a unique handling ensures that
no records exists with the same slug (depending
on the additional settings "unique", "uniqueInSite"
and "uniqueInPid").

The language is considered as well: Records with
the same slug can exist if the language differs.

But language -1 was not considered previously.
Since -1 means all language, no other record with
the same slug should exist in ANY language if a
record with language -1 exists.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 35

  1. Stefan Bürk uploaded patch set 1 01/16/23, 20:31

  2. core-ci voted on patch set 1 V -1 01/16/23, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35895

  3. core-ci voted on patch set 1 V +1 01/16/23, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35895

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 01/16/23, 20:57

  5. Stefan Bürk merged patch set 2 01/16/23, 20:57