Review main Merged

77412[TASK] Use LanguageService in EXT:form TranslationService

Benni Mack CR +2 V +2 Normal +75 −114 updated 01/17/23, 12:45

Commit message

LanguageService can also be used
for overriding labels via TypoScript.

For this reason, TranslationService from
EXT:form can be slimmed down similar
to how Extbase's TranslationUtility was
migrated in:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/77399

Because TranslationService does not have
an input for alternative language keys,
the dependency functionality from
LanguageService can be used.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 711

  1. Benni Mack uploaded patch set 1 01/17/23, 10:09

  2. Benni Mack updated the commit message in patch set 2 01/17/23, 10:11

  3. core-ci voted on patch set 1 V -1 01/17/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35919

  4. core-ci voted on patch set 2 V -1 01/17/23, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35921

  5. Benni Mack rebased onto patch set 3 V -1 01/17/23, 10:55

  6. core-ci voted on patch set 3 V -1 01/17/23, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35933

  7. Benni Mack uploaded patch set 4 V -1 01/17/23, 11:44

  8. core-ci voted on patch set 4 V +1 01/17/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35943

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 01/17/23, 12:39

  10. Anja Leichsenring voted on patch set 4 V +2 CR +2 01/17/23, 12:45

  11. Anja Leichsenring merged patch set 5 01/17/23, 12:45