Review main Abandoned

77415[WIP][TASK] Add optional label attribute as button label

Annett Jähnichen CR 0 V -1 Easy +34 −1 updated 11/19/26, 14:06

Commit message

Add a new label attribute to AbstractControls and LinkButton
to use separate title and label text but keep accessibly information.
Use the more descriptive text as `aria-label` attribute.
If a label should be shown, use a shorter label if is set,
otherwise take the language label from title.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 3

Review log 46

  1. Annett Jähnichen uploaded patch set 1 01/17/23, 11:05

  2. core-ci voted on patch set 1 V -1 01/17/23, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35935

  3. Annett Jähnichen uploaded patch set 2 V -1 01/24/23, 09:52

  4. core-ci voted on patch set 2 V -1 01/24/23, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36526

  5. Benni Mack commented on patch set 2 12/17/24, 16:53

    question: is this patch still valid based on the various changes in v12+v13?
  6. Benni Mack abandoned the change 11/19/26, 14:06