Review main Merged

77419[TASK] Update to PHPStan 1.9.12

Oliver Klee CR +2 V +2 Easy +13 −8 updated 01/17/23, 19:12

Commit message

The new version finds some more potential problems.

> composer req --dev phpstan/phpstan:^1.9.12
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Oliver Klee uploaded patch set 1 01/17/23, 12:11

  2. core-ci voted on patch set 1 V +1 01/17/23, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35950

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/17/23, 13:12

  4. Christian Kuhn merged patch set 2 01/17/23, 13:12

  5. Oliver Hader voted on patch set 2 CR +1 01/17/23, 19:12