Review main Merged

77422[TASK] Simplify TSFE->settingLanguage

Benni Mack CR +2 V +2 Easy +21 −28 updated 01/25/23, 10:11

Commit message

$TSFE->settingLanguage() resolve possibly language
overlays when a page is accessed. This method
has been around for a long time, and with the introduction
of Site handling and its language handling, this method
can be simplified.

* sys_page->getPageOverlay() now is handed in the full default
  language record which is tried to be overlaid, but also
  resolves the full fallback chain.
  This way, including all the caching information from sys_page
  is used, TSFE does not need to retrieve the full record
  from sys_page->getPageOverlay() manually anymore.
* FallbackChain "ignore" can be removed, as it is not possible
  anymore since at least TYPO3 v10 to ignore the fallback
  logic, and the condition can be removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 812

  1. Benni Mack uploaded patch set 1 01/17/23, 14:34

  2. core-ci voted on patch set 1 V -1 01/17/23, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35970

  3. Benni Mack uploaded patch set 2 V -1 01/24/23, 13:53

  4. core-ci voted on patch set 2 V -1 01/24/23, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36546

  5. Benni Mack uploaded patch set 3 V -1 01/24/23, 14:56

  6. core-ci voted on patch set 3 V +1 01/24/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36559

  7. Benni Mack updated the commit message in patch set 4 V +1 01/25/23, 07:48

  8. core-ci voted on patch set 4 V +1 01/25/23, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36598

  9. Georg Ringer voted on patch set 4 V +1 CR +1 01/25/23, 09:24

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 01/25/23, 09:58

  11. Benni Mack voted on patch set 4 V +2 CR +2 01/25/23, 10:11

  12. Benni Mack merged patch set 5 01/25/23, 10:11