Review main Merged

77423[TASK] Clean up Language-related functionality

Benni Mack CR +2 V +2 Normal +36 −60 updated 01/17/23, 19:55

Commit message

This change cleans up
some tests, and also streamlines
some usages (not all of them) of
$TYPO3_CONF_VARS['EXTCONF']['lang']['availableLanguages'].

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1317

  1. Benni Mack uploaded patch set 1 01/17/23, 16:14

  2. core-ci voted on patch set 1 V -1 01/17/23, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35978

  3. Oliver Klee commented on patch set 1 01/17/23, 16:32

    Locales.php:205

    Please let's have an @return annotation that specifies the return type in more detail (both for developers that want to use the new method as well as for better static anlysis).
  4. Benni Mack uploaded patch set 2 V -1 01/17/23, 16:37

  5. core-ci voted on patch set 2 V -1 01/17/23, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35981

  6. Benni Mack uploaded patch set 3 V -1 01/17/23, 17:18

  7. Benni Mack uploaded patch set 4 01/17/23, 17:19

  8. Oliver Klee commented on patch set 4 01/17/23, 17:22

    Locales.php:205 Reply

    Done
  9. core-ci voted on patch set 3 V +1 01/17/23, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35988

  10. core-ci voted on patch set 4 V +1 01/17/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35989

  11. Nikita Hovratov voted on patch set 4 V +1 CR +1 01/17/23, 19:16

  12. Christian Kuhn commented on patch set 4 01/17/23, 19:21

    CacheWarmer.php:31

    all 3 private readonly possible?
  13. Oliver Hader voted on patch set 4 CR +1 01/17/23, 19:25

  14. Benni Mack commented on patch set 4 01/17/23, 19:51

    CacheWarmer.php:31 Reply

    OK in a followup? (see the next in the relation chain)
  15. Christian Kuhn commented on patch set 4 01/17/23, 19:53

    CacheWarmer.php:31 Reply

    Ack
  16. Christian Kuhn voted on patch set 4 V +2 CR +2 01/17/23, 19:55

  17. Christian Kuhn merged patch set 5 01/17/23, 19:55