77460[WIP][TASK] Prevent recursion loop in TypoScript includes
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 6
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractInclude.php+21 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeInterface.php+2 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+2 −2
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/RecursiveImport/setup1.typoscriptnew+3 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/RecursiveImport/setup2.typoscriptnew+3 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php+18 −1
Review log 34
-
Christian Kuhn uploaded patch set 1 01/18/23, 02:36
-
core-ci voted on patch set 1 V -1 01/18/23, 02:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36051
-
Christian Kuhn commented on patch set 1 12/17/24, 11:04
it seems this is not a pressing issue to solve right now and we never got reports recursive looping includes leads to crashes. i'm gonna abandon here for now, this change could potentially be picked up again, in case the issue is to be resolved. -
Christian Kuhn abandoned the change 12/17/24, 11:04