77462[TASK] Streamline output handling for FlashMessages
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php3+1 −1
- typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php+1 −1
- typo3/sysext/core/Classes/Messaging/Renderer/ListRenderer.php+1 −1
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/BootstrapRendererTest.php+18 −3
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/ListRendererTest.php+18 −3
Review log 68
-
Torben Hansen uploaded patch set 1 01/18/23, 10:00
-
core-ci voted on patch set 1 V +1 01/18/23, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36061
-
Oli Bartsch commented on patch set 1 01/18/23, 16:20
-
Torben Hansen commented on patch set 1 01/19/23, 18:26
ModuleTemplate.php:476ReplyI`m pretty unsure if horizontal or vertical tabs are possible/supported in XLIFF files, but to be safe all kind of tabs get removed, we could just use: str_replace(["\t", "\h", "\v"], '', $message->getMessage()) -
Torben Hansen uploaded patch set 2
V +103/01/23, 18:11 -
Torben Hansen commented on patch set 2 03/01/23, 18:12
ModuleTemplate.php:476ReplyDone -
core-ci voted on patch set 2 V +1 03/01/23, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38273
-
Torben Hansen abandoned the change 06/15/24, 12:40
Most likely not needed
ModuleTemplate.php:476