Review main Abandoned

77462[TASK] Streamline output handling for FlashMessages

Torben Hansen CR 0 V 0 Easy +39 −9 updated 06/15/24, 12:40

Commit message

Currently the output of the "message" property of FlashMessages
is not consistent. `BootstrapRenderer` and `ListRenderer` do not
render linebreaks whereas `ModuleTemplate` does. Additionally
`ModuleTemplate` does also render possible tabs in the message
property, which leads to, that the output may look broken if the
message contains tabs.

In order to streamline the output of the message property, this
patch ensures, that:

* Linebreaks in FlashMessages are respected
* Tabs are ignored

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 68

  1. Torben Hansen uploaded patch set 1 01/18/23, 10:00

  2. core-ci voted on patch set 1 V +1 01/18/23, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36061

  3. Oli Bartsch commented on patch set 1 01/18/23, 16:20

    ModuleTemplate.php:476

    This seems a bit to specific. Can we do this in a more general way to also ignore e.g. horizontal "\h" and vertical "\v" tabs?
  4. Torben Hansen commented on patch set 1 01/19/23, 18:26

    ModuleTemplate.php:476 Reply

    I`m pretty unsure if horizontal or vertical tabs are possible/supported in XLIFF files, but to be safe all kind of tabs get removed, we could just use: str_replace(["\t", "\h", "\v"], '', $message->getMessage())
  5. Torben Hansen uploaded patch set 2 V +1 03/01/23, 18:11

  6. Torben Hansen commented on patch set 2 03/01/23, 18:12

    ModuleTemplate.php:476 Reply

    Done
  7. core-ci voted on patch set 2 V +1 03/01/23, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38273

  8. Torben Hansen abandoned the change 06/15/24, 12:40

    Most likely not needed