Review main Abandoned

77490[WIP][TASK] Replace getEnv() with $_ENV in all places

TYPO3com CR 0 V 0 Normal +60 −50 updated 01/22/24, 12:20

Commit message

As per https://github.com/vlucas/phpdotenv#putenv-and-getenv it's
discouraged to use getenv instead of $_ENV due to not being threadsafe.
Furthermore using $_ENV instead of getenv will avoid a bug(?) that
currently happens with symfony/dotenv where getenv will not return
the env variable.

This change aims to allow usage of env vars in all places
when using "symfony/dotenv".

>> temporarly required testing-framework branch to evaulate
   preparation there against the work in this change

Used command(s):

> composer require --dev \
  "typo3/testing-framework":"dev-env-handling-1"

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 19