77495[BUGFIX] Avoid non string argument to str_starts_with()
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 810
-
Henrik Ziegenhain uploaded patch set 1 01/19/23, 11:27
-
Oliver Klee commented on patch set 1 01/19/23, 11:34
I propose we also backport this to 11.5.TranslateViewHelper.php:149I think it would be cleaner to make $id a string from the get-go so the variable has only one type, i.e., add a cast in lines 137 (for $key) and 138 (for $id). -
Christian Kuhn uploaded patch set 2 01/19/23, 11:39
-
Christian Kuhn commented on patch set 2 V +1 CR +1 01/19/23, 11:40
Reply
no such code: VH is very different in v11.TranslateViewHelper.php:149Replyna. should be fine. -
Oliver Klee voted on patch set 2 CR +1 01/19/23, 11:41
-
core-ci voted on patch set 2 V +1 01/19/23, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36213
-
core-ci voted on patch set 1 V +1 01/19/23, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36206
-
Benni Mack voted on patch set 2 V +1 CR +1 01/19/23, 12:20
-
Anja Leichsenring voted on patch set 2 V +2 CR +2 01/19/23, 12:22
-
Anja Leichsenring merged patch set 3 01/19/23, 12:22