Review main Merged

77496[DOCS] Add hint about relative targets in redirects

Josef Glatz CR +2 V +2 Easy +35 −11 updated 01/19/23, 23:30

Commit message

This patch extends the documentation of typo3/cms-redirects by
an example of redirecting to an relative target while using
regular-expressions. This adds more clarity for TYPO3 integrators
and administrators.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1723

  1. Josef Glatz uploaded patch set 1 01/19/23, 11:34

  2. Josef Glatz updated the commit message in patch set 2 01/19/23, 11:35

  3. Josef Glatz commented on patch set 2 01/19/23, 11:36

    This change is ready for review.
  4. core-ci voted on patch set 1 V +1 01/19/23, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36210

  5. Josef Glatz updated the commit message in patch set 3 01/19/23, 12:11

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 01/19/23, 12:15

  7. Nikita Hovratov voted on patch set 3 V +1 CR +1 01/19/23, 12:16

  8. core-ci voted on patch set 2 V -1 01/19/23, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36211

  9. Lina Wolf commented on patch set 3 01/19/23, 12:57

    Index.rst:284

    Please use https://example.org as example domain as links are automatically detected and linked in rst
  10. core-ci voted on patch set 3 V +1 01/19/23, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36222

  11. Josef Glatz commented on patch set 3 01/19/23, 13:11

    Index.rst:284 Reply

    I'm not sure if the initially intended site "mysite" should be still used at if follows also the schema of the existing example. A site must not be a domain. It could be also a `/en` string or a FQDN `https://example.org`. It think this was the intention of the initial writer of this document. But I can update it to use it with the IANA example.org FQDN. Please reply once more with your oppinion.
  12. Josef Glatz commented on patch set 3 CR -1 01/19/23, 13:30

    updating the patch as discussed with Lina
  13. Josef Glatz rebased onto patch set 4 CR +1 V +1 01/19/23, 16:18

  14. core-ci voted on patch set 4 V +1 01/19/23, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36272

  15. Josef Glatz uploaded patch set 5 V +1 01/19/23, 17:24

  16. core-ci voted on patch set 5 V +1 01/19/23, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36284

  17. Chris Müller uploaded patch set 6 V +1 01/19/23, 17:40

  18. core-ci voted on patch set 6 V +1 01/19/23, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36285

  19. Chris Müller voted on patch set 6 V +1 CR +1 01/19/23, 17:59

  20. Josef Glatz commented on patch set 6 01/19/23, 22:01

    Index.rst:284 Reply

    Done
  21. Stefan Bürk voted on patch set 6 V +2 CR +2 01/19/23, 23:30

  22. Stefan Bürk merged patch set 7 01/19/23, 23:30