Review main Merged

77507[TASK] Use local Request Object in Extbase UriBuilder

Anja Leichsenring CR +2 V +2 Normal +106 −28 updated 06/12/23, 04:59

Commit message

The EXT:extbase UriBuilder already has a local instance
of the RequestInterface object, but relies in its method
`buildBackendUrl()` solely on $GLOBALS['TYPO3_REQUEST'].

This is now cleaned up, with a fallback on the global object
in case none has been given as a local instance. In this case,
a deprecation warning will be raised.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1824

  1. Anja Leichsenring uploaded patch set 1 01/19/23, 15:51

  2. core-ci voted on patch set 1 V -1 01/19/23, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36263

  3. Stefan Bürk commented on patch set 1 01/19/23, 23:52

    Maybe to early, but as this are triggering a deprecation notice this should contain a deprecation rest file. But I guess that's on the todo.
  4. Anja Leichsenring uploaded patch set 2 V -1 01/20/23, 08:51

  5. core-ci voted on patch set 2 V -1 01/20/23, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36300

  6. Anja Leichsenring uploaded patch set 3 V -1 01/20/23, 09:12

  7. Anja Leichsenring commented on patch set 3 01/20/23, 09:12

    Reply

    Done
  8. Anja Leichsenring uploaded patch set 4 01/20/23, 09:13

  9. Anja Leichsenring uploaded patch set 5 01/20/23, 09:17

  10. core-ci voted on patch set 4 V -1 01/20/23, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36304

  11. Anja Leichsenring uploaded patch set 6 01/20/23, 09:26

  12. core-ci voted on patch set 5 V +1 01/20/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36306

  13. Oli Bartsch uploaded patch set 7 01/20/23, 09:47

  14. core-ci voted on patch set 6 V +1 01/20/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36309

  15. Benni Mack commented on patch set 7 01/20/23, 09:52

    UriBuilder.php:177

    the method is internal, why would we need a trigger error here?
  16. core-ci voted on patch set 7 V +1 01/20/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36314

  17. Oli Bartsch voted on patch set 7 V +1 CR +1 01/20/23, 10:07

  18. Anja Leichsenring commented on patch set 7 01/20/23, 10:07

    UriBuilder.php:177 Reply

    to be informed if a situation occures, that no valid request object has been handed in. Can still happen if the UriBuilder is initialized by extensions.
  19. Stefan Bürk voted on patch set 7 V +1 CR +1 01/20/23, 10:49

  20. Christian Kuhn commented on patch set 7 V +2 CR +2 01/20/23, 11:01

    UriBuilder.php:177 Reply

    what anja said.
  21. Christian Kuhn merged patch set 8 01/20/23, 11:01

  22. Benni Mack commented on patch set 8 01/23/23, 13:25

    UriBuilder.php:598 Unresolved

    next time, we could also catch this one as well. And then also get rid of $_GET in the tests :) working on a followup.
  23. Torben Hansen commented on patch set 8 01/30/23, 18:08

    This change breaks ext:felogin when a redirect is configured. See https://forge.typo3.org/issues/99757
  24. Stefan Bürk commented on patch set 8 01/31/23, 08:00

    Reply

    Maybe this one will fix it along the way: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77630