77507[TASK] Use local Request Object in Extbase UriBuilder
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/12.2/Deprecation-99650-ExtbaseUriBuilderGlobalRequest.rstnew+42 −0
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php4+14 −7
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+46 −13
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+2 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.php+2 −4
Review log 1824
-
Anja Leichsenring uploaded patch set 1 01/19/23, 15:51
-
core-ci voted on patch set 1 V -1 01/19/23, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36263
-
Stefan Bürk commented on patch set 1 01/19/23, 23:52
Maybe to early, but as this are triggering a deprecation notice this should contain a deprecation rest file. But I guess that's on the todo. -
Anja Leichsenring uploaded patch set 2
V -101/20/23, 08:51 -
core-ci voted on patch set 2 V -1 01/20/23, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36300
-
Anja Leichsenring uploaded patch set 3
V -101/20/23, 09:12 -
Anja Leichsenring commented on patch set 3 01/20/23, 09:12
Reply
Done -
Anja Leichsenring uploaded patch set 4 01/20/23, 09:13
-
Anja Leichsenring uploaded patch set 5 01/20/23, 09:17
-
core-ci voted on patch set 4 V -1 01/20/23, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36304
-
Anja Leichsenring uploaded patch set 6 01/20/23, 09:26
-
core-ci voted on patch set 5 V +1 01/20/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36306
-
Oli Bartsch uploaded patch set 7 01/20/23, 09:47
-
core-ci voted on patch set 6 V +1 01/20/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36309
-
Benni Mack commented on patch set 7 01/20/23, 09:52
UriBuilder.php:177the method is internal, why would we need a trigger error here? -
core-ci voted on patch set 7 V +1 01/20/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36314
-
Oli Bartsch voted on patch set 7 V +1 CR +1 01/20/23, 10:07
-
Anja Leichsenring commented on patch set 7 01/20/23, 10:07
UriBuilder.php:177Replyto be informed if a situation occures, that no valid request object has been handed in. Can still happen if the UriBuilder is initialized by extensions. -
Stefan Bürk voted on patch set 7 V +1 CR +1 01/20/23, 10:49
-
Christian Kuhn commented on patch set 7 V +2 CR +2 01/20/23, 11:01
UriBuilder.php:177Replywhat anja said. -
Christian Kuhn merged patch set 8 01/20/23, 11:01
-
Benni Mack commented on patch set 8 01/23/23, 13:25
UriBuilder.php:598Unresolvednext time, we could also catch this one as well. And then also get rid of $_GET in the tests :) working on a followup. -
Torben Hansen commented on patch set 8 01/30/23, 18:08
This change breaks ext:felogin when a redirect is configured. See https://forge.typo3.org/issues/99757 -
Stefan Bürk commented on patch set 8 01/31/23, 08:00
Reply
Maybe this one will fix it along the way: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77630