Review main Merged

77534[TASK] Clean up AC tests

Christian Kuhn CR +2 V +2 Expert +539 −1067 updated 01/23/23, 13:52

Commit message

* Cest files declared final
* Prefer private over protected
* Remove some skipped tests
* Method comment cleanups

testing-framework raise:
> composer u typo3/testing-framework:dev-main

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 87

Show 67 more files

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/23/23, 12:54

  2. core-ci voted on patch set 1 V +1 01/23/23, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36464

  3. Stefan Bürk voted on patch set 1 CR +1 01/23/23, 13:20

  4. Benni Mack voted on patch set 1 V +1 CR +1 01/23/23, 13:24

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 01/23/23, 13:25

  6. Stefan Bürk voted on patch set 1 V +1 01/23/23, 13:30

  7. core-ci commented on patch set 1 01/23/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36468

  8. Christian Kuhn commented on patch set 1 V +2 CR +2 01/23/23, 13:52

    I'm gonna merge this: Nightly is green and I counted AC tests before/after to be sure we didn't delete too much.
  9. Christian Kuhn merged patch set 2 01/23/23, 13:52