Review main Merged

77538[BUGFIX] Handle disabled default language in PageContentErrorHandler

Oli Bartsch CR +2 V +2 Easy +12 −0 updated 01/23/23, 19:54

Commit message

The SiteInterface provides the "getDefaultLanguage()"
method, which will always return the first configured
language - usually L=0. However, this language might
be disabled, which means, it should not be visible
in frontend context.

The PageContentErrorHandler therefore now tries
to fetch the first enabled language, in case the
requested language id does not exist in the current
site and the sites' default language is disabled.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Oli Bartsch uploaded patch set 1 01/23/23, 15:26

  2. Oli Bartsch uploaded patch set 2 01/23/23, 15:29

  3. core-ci voted on patch set 1 V -1 01/23/23, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36478

  4. core-ci voted on patch set 2 V -1 01/23/23, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36479

  5. Oli Bartsch uploaded patch set 3 V -1 01/23/23, 15:51

  6. core-ci voted on patch set 3 V +1 01/23/23, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36480

  7. Stefan Bürk voted on patch set 3 CR +1 01/23/23, 18:22

  8. Stefan Bürk voted on patch set 3 V +1 01/23/23, 18:29

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/23/23, 18:38

  10. Benni Mack voted on patch set 3 CR +1 01/23/23, 19:50

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 01/23/23, 19:54

  12. Oli Bartsch merged patch set 4 01/23/23, 19:54