Review main Merged

77557[TASK] Cleanup various LanguageService-related code

Benni Mack CR +2 V +2 Easy +17 −18 updated 01/24/23, 09:18

Commit message

Over the past few commits, a lot of changes
happened with LanguageService-related code, mainly
to streamline the initialization and creation
of LanguageService code.

For this reason, various parts have now been sorted
out:
* Proper injection of Locales class
* Consistent usage of LanguageService->init()
* Avoid additional pageRendererSetupTrait call in LoginController
* Avoid using LanguageService->init() if Factory is used
* Leftover "ISOcode" value is removed

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8