77593[BUGFIX] Fix PHP 8 warning in ContentObjectRenderer
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1217
-
Thomas Hohn uploaded patch set 1 01/24/23, 17:38
-
core-ci voted on patch set 1 V +1 01/24/23, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36567
-
Oliver Klee updated the commit message in patch set 2
V +101/24/23, 17:58 -
Oliver Klee voted on patch set 2 CR +1 01/24/23, 17:59
-
core-ci voted on patch set 2 V +1 01/24/23, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36569
-
Nikita Hovratov commented on patch set 2 01/24/23, 18:21
-
Thomas Hohn commented on patch set 2 01/24/23, 18:41
ContentObjectRenderer.php:3115ReplyI'm not sure if there is a condition where tagName is not '' and then $conf['externalBlocks.'][$tagName . '.'] will be null - maybe the commit message is misleading and should be "Since $conf['externalBlocks.'][$tagName . '.'] can be null, added a null coalescing check to ensure that $cfg contains a valid value." instead -
Thomas Hohn updated the commit message in patch set 3
CR +1V +101/24/23, 18:45 -
Thomas Hohn updated the commit message in patch set 4 01/24/23, 18:45
-
Thomas Hohn commented on patch set 4 01/24/23, 18:47
ContentObjectRenderer.php:3115ReplyChanged the commit message to reflect the real purpose of the change. -
Thomas Hohn uploaded patch set 5 01/24/23, 18:51
-
core-ci voted on patch set 3 V +1 01/24/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36570
-
core-ci voted on patch set 4 V +1 01/24/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36571
-
core-ci voted on patch set 5 V +1 01/24/23, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36572
-
Nikita Hovratov commented on patch set 5 V +1 CR +1 01/24/23, 19:53
Thanks! -
Stefan Bürk voted on patch set 5 V +2 CR +2 01/24/23, 20:51
-
Stefan Bürk merged patch set 6 01/24/23, 20:51
ContentObjectRenderer.php:3115