Review main Merged

77595[BUGFIX] Prevent property mapping error in BackendUserGroup DTO

Oli Bartsch CR +2 V +2 Easy +5 −3 updated 01/24/23, 21:07

Commit message

This adds a constructor to the BackendUserGroup DTO,
allowing the extbase ObjectConverter to determine the
correct target type of the "title" property.

Additionally, some cleanup in the DTO is done.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 01/24/23, 19:55

  2. core-ci voted on patch set 1 V +1 01/24/23, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36573

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/24/23, 20:55

  4. Nikita Hovratov voted on patch set 1 V +2 CR +2 01/24/23, 21:07

  5. Nikita Hovratov merged patch set 2 01/24/23, 21:07