Review main Merged

77615[TASK] Use factory for creating content object in LanguageMenuProcessor

Oli Bartsch CR +2 V +2 Easy +5 −1 updated 01/31/23, 09:10

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1417

  1. Oli Bartsch uploaded patch set 1 01/26/23, 15:29

  2. Oli Bartsch uploaded patch set 2 01/26/23, 15:37

  3. Oli Bartsch uploaded patch set 3 01/26/23, 15:38

  4. Oli Bartsch commented on patch set 3 01/26/23, 15:38

    LanguageMenuProcessor.php:254

    Unfortunately, data processors are not marked as internal. Therefore, we can't change the constructor to use DI.
  5. core-ci voted on patch set 3 V +1 01/26/23, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36660

  6. Georg Ringer commented on patch set 3 CR -1 01/27/23, 08:10

    LanguageMenuProcessor.php:254 Reply

    and as it is also not internal we can't be sure that this dataprocessor is extended by another one and using this property, so that would be breaking as well :/
  7. Oli Bartsch uploaded patch set 4 CR -1 V +1 01/27/23, 09:10

  8. Oli Bartsch commented on patch set 4 01/27/23, 09:11

    LanguageMenuProcessor.php:254 Reply

    Yes, you're right.
  9. Georg Ringer voted on patch set 4 V +1 CR +1 01/27/23, 09:11

  10. core-ci voted on patch set 4 V +1 01/27/23, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36678

  11. Jörg Bösche voted on patch set 4 CR +1 01/27/23, 13:51

  12. Oli Bartsch uploaded patch set 5 CR +1 V +1 01/30/23, 14:11

  13. core-ci voted on patch set 5 V +1 01/30/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36769

  14. Jochen Roth voted on patch set 5 V +1 CR +1 01/30/23, 17:13

  15. Benni Mack voted on patch set 5 CR +1 01/31/23, 08:39

  16. Georg Ringer voted on patch set 5 V +2 CR +2 01/31/23, 09:10

  17. Georg Ringer merged patch set 6 01/31/23, 09:10