Review main Merged

77621[BUGFIX] Fix PHP 8 warning in RootlineUtility

Thomas Hohn CR +2 V +2 Easy +18 −1 updated 02/01/23, 14:28

Commit message

Sanitize the mountPointParameter in class constructor.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2429

Show 24 earlier messages
  1. Thomas Hohn uploaded patch set 1 01/27/23, 09:59

  2. Thomas Hohn updated the commit message in patch set 2 01/27/23, 10:02

  3. core-ci voted on patch set 1 V +1 01/27/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36680

  4. core-ci voted on patch set 2 V +1 01/27/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36681

  1. Jörg Bösche voted on patch set 2 CR +1 01/27/23, 13:50

  2. Oliver Klee commented on patch set 2 01/27/23, 16:45

    RootlineUtility.php:379

    You can replace [0-9] with \d (or \\d, to make it explicit to the reader that the backslash should not be string-escaped).
  3. Oliver Klee voted on patch set 2 CR +1 01/27/23, 16:45

  4. Thomas Hohn commented on patch set 2 01/28/23, 08:35

    RootlineUtility.php:379 Reply

    Will have a look a it :-)
  5. Thomas Hohn uploaded patch set 3 CR +1 V +1 01/28/23, 08:54

  6. Thomas Hohn commented on patch set 3 01/28/23, 08:55

    RootlineUtility.php:379 Reply

    Done
  7. core-ci voted on patch set 3 V +1 01/28/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36712

  8. Benni Mack commented on patch set 3 01/30/23, 10:37

    Hey Thomas, do you have an example when this breaks? Does this happen when I just use "&MP=abc--defgb"?
  9. Thomas Hohn commented on patch set 3 01/30/23, 10:40

    Reply

    We have some fault generated url's for instance where &MP=X where x is a number and the -Y is missing - but generates a lot of warnings in our logs..
  10. Oliver Klee voted on patch set 3 CR +1 01/31/23, 17:34

  11. Benni Mack commented on patch set 3 01/31/23, 19:56

    Reply

    How about we sanitize the incoming MP variable in general? I guess this use-case might happen in other places as well.
  12. Thomas Hohn commented on patch set 3 01/31/23, 21:01

    Reply

    Only in this class or in general?
  13. Thomas Hohn commented on patch set 3 01/31/23, 21:06

    Reply

    I assume we could sanitize it in the constructor - will create a new pathset for that
  14. Thomas Hohn uploaded patch set 4 CR +1 V +1 02/01/23, 08:46

  15. core-ci voted on patch set 4 V +1 02/01/23, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36859

  16. Thomas Hohn commented on patch set 4 02/01/23, 08:55

    Reply

    Ack
  17. Oliver Klee voted on patch set 4 CR +1 02/01/23, 09:13

  18. Christian Kuhn uploaded patch set 5 CR +1 V +1 02/01/23, 12:46

  19. Christian Kuhn commented on patch set 4 02/01/23, 12:46

    RootlineUtility.php:376

    the trim() is useless when using trimExplode() anyways.
  20. Christian Kuhn voted on patch set 5 V +1 CR +1 02/01/23, 12:46

  21. core-ci voted on patch set 5 V +1 02/01/23, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36869

  22. Nikita Hovratov voted on patch set 5 V +1 CR +1 02/01/23, 13:15

  23. Stefan Bürk voted on patch set 5 V +1 CR +1 02/01/23, 14:12

  24. Christian Kuhn voted on patch set 5 V +2 CR +2 02/01/23, 14:28

  25. Christian Kuhn merged patch set 6 02/01/23, 14:28