77621[BUGFIX] Fix PHP 8 warning in RootlineUtility
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2429
Show 24 earlier messages
-
Thomas Hohn uploaded patch set 1 01/27/23, 09:59
-
Thomas Hohn updated the commit message in patch set 2 01/27/23, 10:02
-
core-ci voted on patch set 1 V +1 01/27/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36680
-
core-ci voted on patch set 2 V +1 01/27/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36681
-
Jörg Bösche voted on patch set 2 CR +1 01/27/23, 13:50
-
Oliver Klee commented on patch set 2 01/27/23, 16:45
-
Oliver Klee voted on patch set 2 CR +1 01/27/23, 16:45
-
Thomas Hohn commented on patch set 2 01/28/23, 08:35
RootlineUtility.php:379ReplyWill have a look a it :-) -
Thomas Hohn uploaded patch set 3
CR +1V +101/28/23, 08:54 -
Thomas Hohn commented on patch set 3 01/28/23, 08:55
RootlineUtility.php:379ReplyDone -
core-ci voted on patch set 3 V +1 01/28/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36712
-
Benni Mack commented on patch set 3 01/30/23, 10:37
Hey Thomas, do you have an example when this breaks? Does this happen when I just use "&MP=abc--defgb"? -
Thomas Hohn commented on patch set 3 01/30/23, 10:40
Reply
We have some fault generated url's for instance where &MP=X where x is a number and the -Y is missing - but generates a lot of warnings in our logs.. -
Oliver Klee voted on patch set 3 CR +1 01/31/23, 17:34
-
Benni Mack commented on patch set 3 01/31/23, 19:56
Reply
How about we sanitize the incoming MP variable in general? I guess this use-case might happen in other places as well. -
Thomas Hohn commented on patch set 3 01/31/23, 21:01
Reply
Only in this class or in general? -
Thomas Hohn commented on patch set 3 01/31/23, 21:06
Reply
I assume we could sanitize it in the constructor - will create a new pathset for that -
Thomas Hohn uploaded patch set 4
CR +1V +102/01/23, 08:46 -
core-ci voted on patch set 4 V +1 02/01/23, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36859
-
Thomas Hohn commented on patch set 4 02/01/23, 08:55
Reply
Ack -
Oliver Klee voted on patch set 4 CR +1 02/01/23, 09:13
-
Christian Kuhn uploaded patch set 5
CR +1V +102/01/23, 12:46 -
Christian Kuhn commented on patch set 4 02/01/23, 12:46
RootlineUtility.php:376the trim() is useless when using trimExplode() anyways. -
Christian Kuhn voted on patch set 5 V +1 CR +1 02/01/23, 12:46
-
core-ci voted on patch set 5 V +1 02/01/23, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36869
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 02/01/23, 13:15
-
Stefan Bürk voted on patch set 5 V +1 CR +1 02/01/23, 14:12
-
Christian Kuhn voted on patch set 5 V +2 CR +2 02/01/23, 14:28
-
Christian Kuhn merged patch set 6 02/01/23, 14:28
RootlineUtility.php:379