Review main Merged

77625[BUGFIX] Add missing CSS classes in ext:tstemplate InfoModifyTable.html

Torben Hansen CR +2 V +2 Normal +59 −56 updated 01/30/23, 13:58

Commit message

The "Edit TypoScript record" view looks slightly different compared
to TYPO3 v11. This patch adds missing CSS classes in the template,
so the table has a border again and the edit link has a button style.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Torben Hansen uploaded patch set 1 01/28/23, 14:04

  2. core-ci voted on patch set 1 V +1 01/28/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36713

  3. Jasmina Ließmann voted on patch set 1 V +1 CR +1 01/28/23, 17:23

  4. Oli Bartsch commented on patch set 1 01/30/23, 13:18

    InfoModifyMain.html:133

    This class seems to be superfluous as this is the last element in the view.
  5. Jasmina Ließmann uploaded patch set 2 CR +1 V +1 01/30/23, 13:38

  6. Jasmina Ließmann commented on patch set 2 01/30/23, 13:39

    InfoModifyMain.html:133 Reply

    Done
  7. Christian Kuhn rebased onto patch set 3 01/30/23, 13:39

  8. Christian Kuhn commented on patch set 1 01/30/23, 13:39

    InfoModifyMain.html:133 Reply

    Done
  9. Christian Kuhn voted on patch set 3 V +1 CR +1 01/30/23, 13:39

  10. Jasmina Ließmann voted on patch set 3 V +1 CR +1 01/30/23, 13:40

  11. core-ci voted on patch set 2 V +1 01/30/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36766

  12. core-ci voted on patch set 3 V +1 01/30/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36767

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 01/30/23, 13:58

  14. Christian Kuhn merged patch set 4 01/30/23, 13:58