77630[TASK] Drop internal annotation from Extbase's UriBuilder->setRequest()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1518
-
Chris Müller uploaded patch set 1 01/29/23, 17:19
-
Chris Müller updated the commit message in patch set 2 01/29/23, 17:21
-
core-ci voted on patch set 1 V +1 01/29/23, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36733
-
core-ci voted on patch set 2 V +1 01/29/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36734
-
Georg Ringer voted on patch set 2 V +1 CR +1 01/29/23, 19:12
-
Benni Mack commented on patch set 2 CR -1 01/29/23, 20:49
When using getRequest() without setRequest() I get an exception that this is an invalid type. $TYPO3_REQUEST needs to be made compatible when it is set now. -
Christian Kuhn uploaded patch set 3
CR +1V +101/30/23, 13:35 -
core-ci voted on patch set 3 V +1 01/30/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36764
-
Christian Kuhn commented on patch set 3 01/30/23, 14:34
is that fine with you, benni? -
Torben Hansen commented on patch set 3 01/31/23, 08:09
UriBuilder.php:182I don't think we have any place where `$GLOBALS['TYPO3_REQUEST']` is a `RequestInterface`, so this check is not required. -
Benni Mack commented on patch set 3 01/31/23, 08:38
UriBuilder.php:182ReplyI'd leave this currently, as we might need to set "GLOBALS['TYPO3_REQUEST']" in Extbase's RequestBuilder in order to migrate custom extensions slowly to PSR-7 as well. -
Benni Mack voted on patch set 3 CR +1 01/31/23, 08:38
-
Torben Hansen voted on patch set 3 V +1 CR +1 01/31/23, 08:47
-
Christian Kuhn commented on patch set 3 01/31/23, 09:05
UriBuilder.php:182ReplyAck -
Christian Kuhn voted on patch set 3 V +2 CR +2 01/31/23, 09:05
-
Christian Kuhn merged patch set 4 01/31/23, 09:05
-
Torben Hansen commented on patch set 4 01/31/23, 09:28
Post -1 I did not test all scenarios. We can not create a new request in `getRequest()`, since `$GLOBALS['TYPO3_REQUEST']` may not have `extbase` attribute. Currently, `Given request must have an attribute "extbase" of type ExtbaseAttribute` is thrown, when `$GLOBALS['TYPO3_REQUEST']` has no `extbase` attribute. -
Christian Kuhn commented on patch set 4 01/31/23, 12:23