Review main Merged

77637[BUGFIX] Hide modal on forced form engine reload

Oli Bartsch CR +2 V +2 Easy +3 −5 updated 01/31/23, 09:18

Commit message

In case a field change would trigger a form reload,
a corresponding modal must be confirmed by
the user. This modal does now disappear again,
after confirming.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 01/30/23, 13:35

  2. core-ci voted on patch set 1 V +1 01/30/23, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36765

  3. Nikita Hovratov commented on patch set 1 V +1 CR +1 01/30/23, 21:52

    Works, thanks.
  4. Benni Mack voted on patch set 1 V +1 CR +1 01/31/23, 08:38

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 01/31/23, 09:18

  6. Oli Bartsch merged patch set 2 01/31/23, 09:18