Review main Merged

77639[BUGFIX] Fix PHP 8 warning in ContentObjectRenderer

Thomas Hohn CR +2 V +2 Easy +4 −1 updated 02/01/23, 13:13

Commit message

Added a guard around the calculation of $sameBeginEnd.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Thomas Hohn uploaded patch set 1 01/30/23, 14:35

  2. Thomas Hohn updated the commit message in patch set 2 01/30/23, 14:44

  3. core-ci voted on patch set 1 V +1 01/30/23, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36773

  4. core-ci voted on patch set 2 V +1 01/30/23, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36774

  5. Oliver Klee commented on patch set 2 01/31/23, 17:36

    ContentObjectRenderer.php:3465

    Please let's move this type cleanup to a separate change.
  6. Nikita Hovratov commented on patch set 2 01/31/23, 18:00

    ContentObjectRenderer.php:3489

    exploded
  7. Thomas Hohn uploaded patch set 3 V +1 01/31/23, 18:07

  8. Thomas Hohn commented on patch set 3 01/31/23, 18:08

    ContentObjectRenderer.php:3465 Reply

    Will do

    ContentObjectRenderer.php:3489 Reply

    Will fix
  9. core-ci voted on patch set 3 V +1 01/31/23, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36836

  10. Thomas Hohn commented on patch set 3 01/31/23, 18:17

    ContentObjectRenderer.php:3465 Reply

  11. Oliver Klee voted on patch set 3 CR +1 02/01/23, 09:16

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 02/01/23, 12:41

  13. Nikita Hovratov voted on patch set 3 V +2 CR +2 02/01/23, 13:12

  14. Nikita Hovratov merged patch set 4 02/01/23, 13:13