Review main Abandoned

77641[TASK] Move methods from EXT:install->setup*Service to EXT:backend

Jochen Roth CR 0 V 0 Normal +107 −94 updated 01/31/23, 10:22

Commit message

To avoid a dependency from EXT:backend to EXT:install the
methods getBackendUserPasswordValidationErrors, createUser
and getHashedPassword have been moved to BackendUserUtility
in EXT:backend.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 1017

  1. Jochen Roth uploaded patch set 1 01/30/23, 15:45

  2. core-ci voted on patch set 1 V -1 01/30/23, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36778

  3. core-ci commented on patch set 1 01/30/23, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36778

  4. core-ci voted on patch set 1 V +1 01/30/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36778

  5. Oli Bartsch commented on patch set 1 01/30/23, 17:36

    BackendUserUtility.php:32 Unresolved

    I assume this class could be final and also marked as @internal, right? Since the class does not work with static methods (which Core "Utility" classes usually do) we might want to use "Service" instead of "Utility". IMO we can also make the methods static and use "Utility". This way, we could remove the additional code from the ServiceProvider. We actually removed some of those Services lately, see e.g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/77416.

    BackendUserUtility.php:41 Unresolved

    Could be injected

    BackendUserUtility.php:74 Unresolved

    Could be injected
  6. Jochen Roth uploaded patch set 2 V +1 01/30/23, 18:53

  7. Jochen Roth uploaded patch set 3 01/30/23, 18:56

  8. core-ci voted on patch set 2 V +1 01/30/23, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36788

  9. core-ci voted on patch set 3 V +1 01/30/23, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36790

  10. Jochen Roth uploaded patch set 4 V +1 01/30/23, 19:51

  11. core-ci voted on patch set 4 V +1 01/30/23, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36793

  12. Jochen Roth commented on patch set 4 CR -1 01/30/23, 23:51

    On it
  13. Jochen Roth uploaded patch set 5 CR -1 V +1 01/31/23, 08:39

  14. core-ci voted on patch set 5 V +1 01/31/23, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36808

  15. Benni Mack commented on patch set 5 01/31/23, 09:04

    please no new utility class. Static methods are horrible for DI and for testing. let's distribute the functionality in places where they are suited in a better way: * createUser -> EXT:backend/Classes/Repository/BackendUserRepository.php * validationErrors -> somewhere under passwordpolicy * passwordHashing -> PasswordHashFactory
  16. Jochen Roth abandoned the change 01/31/23, 10:17

    Talked to lolli, we plan to simply copy these methods to avoid any dependency between EXT:install <vs> EXT:backend
  17. Jochen Roth commented on patch set 5 01/31/23, 10:22