77641[TASK] Move methods from EXT:install->setup*Service to EXT:backend
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/backend/Classes/Utility/BackendUserUtility.php3new+98 −0
- typo3/sysext/install/Classes/Command/SetupCommand.php+4 −3
- typo3/sysext/install/Classes/Controller/InstallerController.php+3 −2
- typo3/sysext/install/Classes/Service/SetupDatabaseService.php+0 −19
- typo3/sysext/install/Classes/Service/SetupService.php+2 −70
Review log 1017
-
Jochen Roth uploaded patch set 1 01/30/23, 15:45
-
core-ci voted on patch set 1 V -1 01/30/23, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36778
-
core-ci commented on patch set 1 01/30/23, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36778
-
core-ci voted on patch set 1 V +1 01/30/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36778
-
Oli Bartsch commented on patch set 1 01/30/23, 17:36
BackendUserUtility.php:41UnresolvedCould be injectedBackendUserUtility.php:74UnresolvedCould be injected -
Jochen Roth uploaded patch set 2
V +101/30/23, 18:53 -
Jochen Roth uploaded patch set 3 01/30/23, 18:56
-
core-ci voted on patch set 2 V +1 01/30/23, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36788
-
core-ci voted on patch set 3 V +1 01/30/23, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36790
-
Jochen Roth uploaded patch set 4
V +101/30/23, 19:51 -
core-ci voted on patch set 4 V +1 01/30/23, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36793
-
Jochen Roth commented on patch set 4 CR -1 01/30/23, 23:51
On it -
Jochen Roth uploaded patch set 5
CR -1V +101/31/23, 08:39 -
core-ci voted on patch set 5 V +1 01/31/23, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36808
-
Benni Mack commented on patch set 5 01/31/23, 09:04
please no new utility class. Static methods are horrible for DI and for testing. let's distribute the functionality in places where they are suited in a better way: * createUser -> EXT:backend/Classes/Repository/BackendUserRepository.php * validationErrors -> somewhere under passwordpolicy * passwordHashing -> PasswordHashFactory -
Jochen Roth abandoned the change 01/31/23, 10:17
Talked to lolli, we plan to simply copy these methods to avoid any dependency between EXT:install <vs> EXT:backend -
Jochen Roth commented on patch set 5 01/31/23, 10:22
BackendUserUtility.php:32Unresolved