Review main Abandoned

77642[BUGFIX] Display the category tree if a single starting point is set

Florian Rival CR 0 V 0 Easy +10 −3 updated 07/30/25, 11:29

Commit message

Check if the parent category is in the mount point category and if so
we can certify that children are safe.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 1522

  1. Florian Rival uploaded patch set 1 01/30/23, 16:31

  2. core-ci voted on patch set 1 V -1 01/30/23, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36782

  3. Georg Ringer uploaded patch set 2 V -1 02/05/23, 19:51

  4. core-ci voted on patch set 2 V +1 02/05/23, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37126

  5. Henrik Elsner commented on patch set 2 V +1 CR +1 03/06/23, 09:34

    Very important and working patch! Thanks a lot
  6. Stefan Bürk commented on patch set 2 CR -1 03/06/23, 10:20

    Please reformat the commit message. There are rules about the line length (max 72 chars), also up to 74 may accepted. Therefor: * rewrite the first line so it matches that * ensure the message lines are not exceeding this by adding manual line breaks. See for body: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#description-message-body And for summary line: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#summary-line-first-line
  7. Florian Rival updated the commit message in patch set 3 CR +1 V +1 03/06/23, 10:36

  8. core-ci voted on patch set 3 V -1 03/06/23, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38539

  9. Nikita Hovratov commented on patch set 3 V -1 03/06/23, 11:13

    Your fix only works for the exact case where: - The user category mountpoint is equal to the startingpoint But if the startingoint is a child of the user category mountpoint, the bug occurs again.
  10. Benni Mack updated the commit message in patch set 4 V -1 05/03/23, 09:33

  11. Benni Mack updated the commit message in patch set 5 10/15/24, 10:07

  12. core-ci voted on patch set 5 V -1 10/15/24, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67828

  13. Oliver Hader updated the commit message in patch set 6 V -1 10/18/24, 13:55

  14. Oliver Hader rebased onto patch set 7 11/20/24, 17:00

  15. core-ci voted on patch set 7 V +1 11/20/24, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69820

  16. Benni Mack commented on patch set 8 V +1 03/28/25, 11:47

    Published edit on patch set 7.
  17. Benni Mack rebased onto patch set 9 03/28/25, 11:47

  18. core-ci voted on patch set 8 V -1 03/28/25, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76574

  19. core-ci voted on patch set 9 V +1 03/28/25, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76575

  20. Benni Mack commented on patch set 9 03/28/25, 12:06

    See nikita's comment, apparantly we need to work on this. putting this into WIP until somebody picks it up.
  21. Benni Mack marked it work in progress 03/28/25, 12:06

  22. Andreas Kienast abandoned the change 07/30/25, 11:29

    Thank you for your patch. There is another patch available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87780 that solves the issue as well, therefore I'm closing this one. Again, thanks for your contribution.