Review main Merged

77643[BUGFIX] Apply TCA migrations for FlexForm in DataHandler

Nikita Hovratov CR +2 V +2 Normal +58 −93 updated 02/03/23, 09:00

Commit message

So far TCA migrations for FlexForm were only called in FormEngine
context. In order for DataHandler to always receive migrated TCA, the
migration method is now moved from TcaFlexPrepare to FlexFormTools.

This also fixes TCA type="file" fields inside FlexForm. TcaFlexPrepare
used the TcaPreparation functionality, which would override the TCA
foreign_match_fields with "dummyField" instead if the FlexForm sub key.

In addition, a typo in a parameter name is fixed as a drive-by change.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4