Review main Merged

77653[TASK] Update d3 library to v3.0

Benni Mack CR +2 V +2 Normal +45 −42 updated 02/01/23, 07:02

Commit message

Used command:

  cd Build
  npm install "d3-drag@^3.0.0" \
    "d3-selection@^3.0.0" \
    "d3-dispatch@^3.0.0" \
    "@types/d3-dispatch@^3.0.0" \
    "@types/d3-drag@^3.0.0" \
    "@types/d3-selection@^3.0.0
  grunt build

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Benni Mack uploaded patch set 1 01/31/23, 20:36

  2. core-ci voted on patch set 1 V +1 01/31/23, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36842

  3. Benni Mack updated the commit message in patch set 2 V +1 01/31/23, 20:48

  4. core-ci voted on patch set 2 V +1 01/31/23, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36844

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 01/31/23, 21:04

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 02/01/23, 07:02

  7. Andreas Kienast merged patch set 3 02/01/23, 07:02