Review main Merged

77654[TASK] Clean up various TypeScript code for SVG tree

Benni Mack CR +2 V +2 Hard +205 −214 updated 02/01/23, 09:07

Commit message

This change reduces some redundancy in implementations
for drag+drop for pagetree + folder tree,
also adds some comments and adds
some helper methods to make the code
a tiny bit more understandable.

In addition, to reduce our dependencies to
d3-drag, the DragDropHandlers now receive
the node and the original MouseEvent,
as there is nothing else that the DragDrop
handlers need for our solutions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 914

  1. Benni Mack uploaded patch set 1 01/31/23, 20:44

  2. core-ci voted on patch set 1 V +1 01/31/23, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36843

  3. Benni Mack uploaded patch set 2 V +1 01/31/23, 21:28

  4. core-ci voted on patch set 2 V +1 01/31/23, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36845

  5. Benni Mack uploaded patch set 3 V +1 01/31/23, 21:42

  6. core-ci voted on patch set 3 V +1 01/31/23, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36846

  7. Benni Mack uploaded patch set 4 V +1 01/31/23, 22:12

  8. Benni Mack uploaded patch set 5 01/31/23, 22:15

  9. core-ci voted on patch set 4 V +1 01/31/23, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36847

  10. core-ci voted on patch set 5 V +1 01/31/23, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36848

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 02/01/23, 08:24

  12. Andreas Kienast voted on patch set 5 V +1 CR +1 02/01/23, 09:07

  13. Andreas Kienast voted on patch set 5 V +2 CR +2 02/01/23, 09:07

  14. Andreas Kienast merged patch set 6 02/01/23, 09:07