Review main Merged

77656[TASK] Further refactorings of SVG tree drag+drop code

Benni Mack CR +2 V +2 Hard +216 −155 updated 02/01/23, 15:21

Commit message

This change is the next iteration
of cleaning up SVG-drag/drop code.

Handling of the "positioning line" to drag nodes
between other nodes (page tree only)
has been encapsulated in drag-drop.ts

A lot of methods and variables are renamed and comments
are added in order to understand the code better.

A few methods regarding draggables (the shadowed content) have
been centralized so the code is easier to
read where CSS classes are modified.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 67

  1. Benni Mack uploaded patch set 1 02/01/23, 11:20

  2. core-ci voted on patch set 1 V +1 02/01/23, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36866

  3. Andreas Kienast voted on patch set 1 CR +1 02/01/23, 12:02

  4. Andreas Kienast voted on patch set 1 V +1 02/01/23, 12:22

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 02/01/23, 15:21

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 02/01/23, 15:21

  7. Andreas Kienast merged patch set 2 02/01/23, 15:21