Review main Merged

77660[TASK] Use default font color in system information dropdown

Jasmina Ließmann CR +2 V +2 Normal +63 −21 updated 02/03/23, 16:22

Commit message

To improve readability, the system status text and value of the
application context are displayed in default font color.
The link to the system log is now also displayed in the default
link color.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1824

  1. Jasmina Ließmann uploaded patch set 1 02/01/23, 16:38

  2. core-ci voted on patch set 1 V +1 02/01/23, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36889

  3. Jasmina Ließmann updated the commit message in patch set 2 V +1 02/01/23, 16:56

  4. Jasmina Ließmann updated the commit message in patch set 3 02/01/23, 16:58

  5. core-ci voted on patch set 2 V +1 02/01/23, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36892

  6. core-ci voted on patch set 3 V +1 02/01/23, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36893

  7. Jasmina Ließmann updated the commit message in patch set 4 V +1 02/01/23, 17:33

  8. core-ci voted on patch set 4 V +1 02/01/23, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36897

  9. Andreas Kienast commented on patch set 4 V -1 02/02/23, 09:46

    This looks pretty weird, please see my screenshot at https://imgur.com/a/G07elOk. Don't mind the scrollbars, tho.
  10. Stefan Bürk commented on patch set 4 02/02/23, 10:57

    Reply

    Yeah .. already send screenshot over slack to Jasmina ;) just forgot to -1 and mention here. She will have a look on it. Can you say which browser/os you used for the screenshot ?
  11. Andreas Kienast commented on patch set 4 02/02/23, 11:14

    Reply

    Fedora 37 with GNOME 43.2 and Chrome 109.0.5414.119
  12. Jasmina Ließmann uploaded patch set 5 V +1 02/02/23, 19:35

  13. Jasmina Ließmann commented on patch set 5 02/02/23, 19:39

    Reply

    Thanks for your feedback. Unfortunately, I cannot reproduce the error on my operating system. I rewrote that part, please take a look and let me know if it looks better now.
  14. core-ci voted on patch set 5 V -1 02/02/23, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36931

  15. Jasmina Ließmann uploaded patch set 6 V -1 02/02/23, 20:17

  16. core-ci voted on patch set 6 V +1 02/02/23, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36933

  17. Andreas Kienast commented on patch set 6 V +1 CR +1 02/03/23, 09:17

    Much better, thanks!
  18. Andreas Kienast commented on patch set 6 02/03/23, 09:17

    Reply

    Done
  19. Stefan Bürk commented on patch set 6 CR -1 02/03/23, 09:25

    on it ..
  20. Stefan Bürk commented on patch set 6 V +2 CR +2 02/03/23, 09:27

    Yeah, looks fine now. Appreciate this little change. Thanks for it !
  21. Stefan Bürk merged patch set 7 02/03/23, 09:27

  22. Benjamin Kott commented on patch set 7 02/03/23, 09:51

    post -1

    SystemInformationDropDown.html:77

    why are we adding utility css classes here again while introducing new css classes?
  23. Benjamin Kott commented on patch set 7 02/03/23, 09:53

    _dropdown.scss:184

    add css for dropdown-row, use padding on row, gap for spacing between items. remove individual css on elements.
  24. Jasmina Ließmann commented on patch set 7 02/03/23, 16:22

    _dropdown.scss:184 Reply

    Thanks for your feedback. Please have a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77683. Feel free to leave a note or modify the patch set by your desire.

    SystemInformationDropDown.html:77 Reply

    Done