Review main Merged

77664[TASK] Prefer browser tooltips over bootstrap tooltips

Christian Kuhn CR +2 V +2 Hard +115 −191 updated 02/04/23, 15:23

Commit message

The entire bootstrap tooltips plugin and Backend
handling is problemetic. The patch removes usages
throughout the Backend to rely solely on native
browser title attributes on hover for now.

Reasons:
* Usage within the Backend is very inconsistent: Some
  modules use 'bs-toggle="tooltip"', some do, but then
  don't initialze JS accordingly, many don't take care
  at all.
* The placement of tooltips is inconsistent: Some modules
  rely on auto placement, some don't take care, some
  get it right.
* The plugin is fiddly: There are various hacks to for
  instance toggle-off on scroll, or toggle-off when a
  modal is overlayed to not stay on-top-of modals, these
  sort of things. Browser title hovers always get this right.
* Usages are buggy: The page tree sometimes still fails
  to remove tooltips, which then tend to stay until browser
  reload. The list module shows both a browser hover plus
  the tooltip at the same time on icons, ext:form shows funny
  placement in preview-mode. There are more modules that get
  details wrong than those that work flawlessly.
* Tooltips that add a lot of valuable information are
  problematic from an accessibility point of view. It's
  better to refactor UI to not rely on them too much. By
  avoiding bootstrap tooltips for now, we encourage to
  think more about properly accessible solutions instead
  of putting things into a "nice" overlay. With the patch,
  various places now fall back to the title attribute, which
  is also problematic, see [1] for more information. The
  core will continue to improve the situation with
  further patches and will document better best practices.
* Tooltips with a lot of additional information are a
  no-go on touch devices.
* The plugin is slow with many elements. This is easily
  reproducible with the "List" module, which is noticeable
  quicker when relying on title tags alone on weaker clients.

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#accessibility_concerns

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 7

Files 53

Show 33 more files