Review main Merged

77668[TASK] Cache state in collapse-state-persister

Andreas Kienast CR +2 V +2 Easy +25 −13 updated 02/02/23, 18:41

Commit message

The module `@typo3/backend/utility/collapse-state-persister` performs
several JSON decoding tasks on the same objects that are read from the
client's localStorage. To save some milliseconds, a `Map`-based cache
is introduced that saves some JSON operations, depending on how many
nodes are expanded.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 02/02/23, 07:16

  2. core-ci voted on patch set 1 V +1 02/02/23, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36914

  3. Andreas Kienast uploaded patch set 2 V +1 02/02/23, 07:23

  4. core-ci voted on patch set 2 V +1 02/02/23, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36915

  5. Stefan Bürk voted on patch set 2 CR +1 02/02/23, 08:08

  6. Stefan Bürk voted on patch set 2 V +1 02/02/23, 08:16

  7. Christian Kuhn commented on patch set 2 V +2 CR +2 02/02/23, 18:41

    cool. thx!
  8. Christian Kuhn merged patch set 3 02/02/23, 18:41