Review 11.5 Merged

77670[BUGFIX] Fix PHP 8 warning in ExtendedTemplateService

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 02/03/23, 16:29

Commit message

The method getTemplateQueryBuilder has a reference to
$GLOBALS['BE_USER']->workspace. This value should be
fetched via the WorkspaceAspect.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Thomas Hohn uploaded patch set 1 02/02/23, 07:49

  2. core-ci voted on patch set 1 V +1 02/02/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36918

  3. Oliver Klee voted on patch set 1 CR +1 02/02/23, 09:02

  4. Benni Mack voted on patch set 1 CR +1 02/02/23, 14:15

  5. Benni Mack voted on patch set 1 V +1 02/03/23, 16:11

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 02/03/23, 16:29

  7. Christian Kuhn merged patch set 2 02/03/23, 16:29