Review main Merged

77671[BUGFIX] Disable drag&drop from files within EXT:filelist module

Andreas Kienast CR +2 V +2 Easy +14 −1 updated 02/02/23, 15:06

Commit message

This patch introduces a flag that enables itself once dragging was
started within the document of the filelist module. If the flag is
enabled, the drag&drop upload feature is *disabled* to avoid dragging
an image within the filelist and having a fullsize dropzone rendered,
which in fact accepts the dragged thumbnail and uploads it in the same
directory.

However, this will not prevent receiving images from anywhere else of
the TYPO3 backend as those are technically "external" files.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 02/02/23, 14:18

  2. Benni Mack voted on patch set 1 CR +1 02/02/23, 14:19

  3. core-ci voted on patch set 1 V +1 02/02/23, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36927

  4. Benni Mack voted on patch set 1 V +1 02/02/23, 14:30

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 02/02/23, 15:06

  6. Oli Bartsch merged patch set 2 02/02/23, 15:06