Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
77679[WIP][FEATURE] Introduce ModifyRedirectServiceUriFromCustomLinkDetailsEvent
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 27
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/77679/27 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/77679/27 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 2
Files 6
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-99805-NewPSR-14ModifyRedirectServiceUriFromCustomLinkDetailsEvent.rstnew+120 −0
- typo3/sysext/redirects/Classes/Event/ModifyRedirectServiceUriFromCustomLinkDetailsEvent.phpnew+93 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php+23 −1
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_ModifyRedirectServiceUriFromCustomLinkDetailsEvent.csvnew+8 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+106 −1
- typo3/sysext/redirects/Tests/Unit/Event/ModifyRedirectServiceUriFromCustomLinkDetailsEventTest.phpnew+82 −0
Review log 4168
Show 2543 earlier messages
-
Stefan Bürk uploaded patch set 1 02/03/23, 09:17
-
core-ci voted on patch set 1 V -1 02/03/23, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36967
-
Stefan Bürk uploaded patch set 2
V -102/04/23, 23:15 -
core-ci voted on patch set 2 V -1 02/05/23, 00:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37084
-
Stefan Bürk uploaded patch set 3
V -102/05/23, 00:47 -
core-ci voted on patch set 3 V +1 02/05/23, 00:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37086
-
Stefan Bürk uploaded patch set 4
V +102/05/23, 01:03 -
core-ci voted on patch set 4 V -1 02/05/23, 01:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37088
-
Stefan Bürk uploaded patch set 5
V -102/05/23, 13:59 -
Stefan Bürk uploaded patch set 6 02/05/23, 14:00
-
core-ci voted on patch set 5 V +1 02/05/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37111
-
core-ci voted on patch set 6 V +1 02/05/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37112
-
Stefan Bürk uploaded patch set 7
V +102/05/23, 14:44 -
Stefan Bürk updated the commit message in patch set 8 02/05/23, 14:45
-
Stefan Bürk updated the commit message in patch set 9 02/05/23, 14:45
-
Stefan Bürk commented on patch set 9 CR -1 02/05/23, 14:46
-1 because this **must** be merged after https://review.typo3.org/c/Packages/TYPO3.CMS/+/77675 - as it refers to that change in the changelog. -
core-ci voted on patch set 9 V +1 02/05/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37116
-
core-ci voted on patch set 8 V +1 02/05/23, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37115
-
core-ci voted on patch set 7 V +1 02/05/23, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37114
-
Stefan Bürk commented on patch set 10
CR -1V +102/05/23, 19:56Published edit on patch set 9. -
core-ci voted on patch set 10 V +1 02/05/23, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37129
-
Chris Müller uploaded patch set 11
V +102/08/23, 17:49 -
core-ci voted on patch set 11 V +1 02/08/23, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37398
-
Stefan Bürk voted on patch set 11 CR -1 02/09/23, 20:24
-
Stefan Bürk uploaded patch set 12
CR -1V +102/23/23, 10:42 -
core-ci voted on patch set 12 V +1 02/23/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38005
-
Sybille Peters commented on patch set 12 02/25/23, 14:23
Just repeating the -1: > 1 because this must be merged after https://review.typo3.org/c/Packages/TYPO3.CMS/+/77675 - as it refers to that change in the changelog.Feature-99805-NewPSR-14ModifyRedirectServiceLinkBuilderBuildArgumentsEvent.rst:14For the reader not so familiar with the core: Might help to say when the event is dispatched (when a redirect is hit in the FE). -
Stefan Bürk uploaded patch set 13
V +102/26/23, 14:41 -
Stefan Bürk uploaded patch set 14 02/26/23, 14:45
-
Stefan Bürk commented on patch set 13 02/26/23, 14:46
Reply
Removed the reference, therefor not blocking anymore.Feature-99805-NewPSR-14ModifyRedirectServiceLinkBuilderBuildArgumentsEvent.rst:14ReplyChanged it, hope thats sufficient to make this more clearer. -
Sybille Peters voted on patch set 14 CR +1 02/26/23, 14:51
-
core-ci voted on patch set 14 V +1 02/26/23, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38116
-
core-ci voted on patch set 13 V +1 02/26/23, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38115
-
Jochen Roth updated the commit message in patch set 15
CR +1V +103/16/23, 15:39 -
core-ci voted on patch set 15 V -1 03/16/23, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39061
-
Stefan Bürk rebased onto patch set 16
V -103/17/23, 05:21 -
core-ci voted on patch set 16 V +1 03/17/23, 05:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39093
-
Stefan Bürk uploaded patch set 17
V +103/17/23, 06:03 -
core-ci voted on patch set 17 V +1 03/17/23, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39096
-
Stefan Bürk uploaded patch set 18
V +103/18/23, 17:01 -
core-ci voted on patch set 18 V +1 03/18/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39189
-
Benni Mack voted on patch set 18 CR +1 03/22/23, 19:37
-
Stefan Bürk uploaded patch set 19
CR +1V +103/22/23, 19:51
-
core-ci voted on patch set 19 V +1 03/22/23, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39414
-
Benni Mack commented on patch set 19 03/27/23, 08:24
I wonder if this specific Event is useful as is... All we can now do is modify the very "typolink" specific internals for this event. I'd rather have a AfterRedirectLinkWasGeneratedEvent($redirectRecord, $incomingRequest, $configuration, UriInterface $createdRedirect). This way, the extension author has much more power over the actual final URL and can then decide if she/he needs to re-create/modify or just leave the URL? -
Stefan Bürk commented on patch set 19 03/27/23, 08:30
Reply
I added this event based on a user request (longer talk, screenshare). Currently, the they xclass RedirectService to manipulate settings for the generation exactly on that place. So I would say, it's not completly useless. As this event with others helps them to avoid xclassing I would go forward to add this event anyway. We can considier to add an additional event in the end then, but I guess I would not find the time to finish the other event in time before freeze release. -
Stefan Bürk wrote 03/27/23, 08:30
Removed cc Andri Steiner. -
Stefan Bürk commented on patch set 20
V +103/27/23, 08:35Published edit on patch set 19. -
Stefan Bürk rebased onto patch set 21 03/27/23, 08:36
-
core-ci voted on patch set 20 V +1 03/27/23, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39673
-
core-ci voted on patch set 21 V +1 03/27/23, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39674
-
Simon Schaufelberger uploaded patch set 22
V +108/24/23, 14:47 -
core-ci voted on patch set 22 V -1 08/24/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45787
-
Simon Schaufelberger uploaded patch set 23
V -108/24/23, 14:57 -
core-ci voted on patch set 23 V +1 08/24/23, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45788
-
Jörg Bösche voted on patch set 23 CR +1 08/25/23, 13:49
-
Stefan Bürk uploaded patch set 24
CR +1V +109/27/23, 14:57 -
Stefan Bürk updated the commit message in patch set 25 09/27/23, 14:59
-
Stefan Bürk uploaded patch set 26 09/27/23, 15:01
-
core-ci voted on patch set 24 V +1 09/27/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47249
-
core-ci voted on patch set 25 V +1 09/27/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47250
-
core-ci voted on patch set 26 V +1 09/27/23, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47251
-
Sybille Peters wrote 10/27/23, 06:14
Removed reviewer Sybille Peters. -
Stefan Bürk rebased onto patch set 27
V +111/29/23, 08:48 -
core-ci voted on patch set 27 V -1 11/29/23, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50095
-
Benni Mack wrote 01/30/24, 14:28
Removed reviewer Benni Mack. -
Benni Mack wrote 03/22/25, 16:41
Topic set to redirects -
Benni Mack marked it work in progress 03/28/25, 13:52