Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

77679[WIP][FEATURE] Introduce ModifyRedirectServiceUriFromCustomLinkDetailsEvent

Stefan Bürk CR 0 V -1 Hard +432 −2 updated 03/28/25, 13:52

Commit message

A new PSR-14 event `ModifyRedirectServiceUriFromCustomLinkDetailsEvent`
is introduced, allowing extension authors to modify the arguments passed
to `LinkBuilder->build()`. This can be used to modify the configuration
based on custom redirect record values, e.g. added by using the PSR-14
event introduced with #99803.

@todo's

* Needs additional tests for new event properties.
* adjust commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 27
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/77679/27 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/77679/27 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 2

Files 6

Review log 4168

Show 2543 earlier messages
  1. Stefan Bürk uploaded patch set 1 02/03/23, 09:17

  2. core-ci voted on patch set 1 V -1 02/03/23, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36967

  3. Stefan Bürk uploaded patch set 2 V -1 02/04/23, 23:15

  4. core-ci voted on patch set 2 V -1 02/05/23, 00:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37084

  5. Stefan Bürk uploaded patch set 3 V -1 02/05/23, 00:47

  6. core-ci voted on patch set 3 V +1 02/05/23, 00:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37086

  7. Stefan Bürk uploaded patch set 4 V +1 02/05/23, 01:03

  8. core-ci voted on patch set 4 V -1 02/05/23, 01:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37088

  9. Stefan Bürk uploaded patch set 5 V -1 02/05/23, 13:59

  10. Stefan Bürk uploaded patch set 6 02/05/23, 14:00

  11. core-ci voted on patch set 5 V +1 02/05/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37111

  12. core-ci voted on patch set 6 V +1 02/05/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37112

  13. Stefan Bürk uploaded patch set 7 V +1 02/05/23, 14:44

  14. Stefan Bürk updated the commit message in patch set 8 02/05/23, 14:45

  15. Stefan Bürk updated the commit message in patch set 9 02/05/23, 14:45

  16. Stefan Bürk commented on patch set 9 CR -1 02/05/23, 14:46

    -1 because this **must** be merged after https://review.typo3.org/c/Packages/TYPO3.CMS/+/77675 - as it refers to that change in the changelog.
  17. core-ci voted on patch set 9 V +1 02/05/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37116

  18. core-ci voted on patch set 8 V +1 02/05/23, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37115

  19. core-ci voted on patch set 7 V +1 02/05/23, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37114

  20. Stefan Bürk commented on patch set 10 CR -1 V +1 02/05/23, 19:56

    Published edit on patch set 9.
  21. core-ci voted on patch set 10 V +1 02/05/23, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37129

  22. Chris Müller uploaded patch set 11 V +1 02/08/23, 17:49

  23. core-ci voted on patch set 11 V +1 02/08/23, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37398

  24. Stefan Bürk voted on patch set 11 CR -1 02/09/23, 20:24

  25. Stefan Bürk uploaded patch set 12 CR -1 V +1 02/23/23, 10:42

  26. core-ci voted on patch set 12 V +1 02/23/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38005

  27. Sybille Peters commented on patch set 12 02/25/23, 14:23

    Just repeating the -1: > 1 because this must be merged after https://review.typo3.org/c/Packages/TYPO3.CMS/+/77675 - as it refers to that change in the changelog.

    Feature-99805-NewPSR-14ModifyRedirectServiceLinkBuilderBuildArgumentsEvent.rst:14

    For the reader not so familiar with the core: Might help to say when the event is dispatched (when a redirect is hit in the FE).
  28. Stefan Bürk uploaded patch set 13 V +1 02/26/23, 14:41

  29. Stefan Bürk uploaded patch set 14 02/26/23, 14:45

  30. Stefan Bürk commented on patch set 13 02/26/23, 14:46

    Reply

    Removed the reference, therefor not blocking anymore.

    Feature-99805-NewPSR-14ModifyRedirectServiceLinkBuilderBuildArgumentsEvent.rst:14 Reply

    Changed it, hope thats sufficient to make this more clearer.
  31. Sybille Peters voted on patch set 14 CR +1 02/26/23, 14:51

  32. core-ci voted on patch set 14 V +1 02/26/23, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38116

  33. core-ci voted on patch set 13 V +1 02/26/23, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38115

  34. Jochen Roth updated the commit message in patch set 15 CR +1 V +1 03/16/23, 15:39

  35. core-ci voted on patch set 15 V -1 03/16/23, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39061

  36. Stefan Bürk rebased onto patch set 16 V -1 03/17/23, 05:21

  37. core-ci voted on patch set 16 V +1 03/17/23, 05:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39093

  38. Stefan Bürk uploaded patch set 17 V +1 03/17/23, 06:03

  39. core-ci voted on patch set 17 V +1 03/17/23, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39096

  40. Stefan Bürk uploaded patch set 18 V +1 03/18/23, 17:01

  41. core-ci voted on patch set 18 V +1 03/18/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39189

  42. Benni Mack voted on patch set 18 CR +1 03/22/23, 19:37

  43. Stefan Bürk uploaded patch set 19 CR +1 V +1 03/22/23, 19:51

  1. core-ci voted on patch set 19 V +1 03/22/23, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39414

  2. Benni Mack commented on patch set 19 03/27/23, 08:24

    I wonder if this specific Event is useful as is... All we can now do is modify the very "typolink" specific internals for this event. I'd rather have a AfterRedirectLinkWasGeneratedEvent($redirectRecord, $incomingRequest, $configuration, UriInterface $createdRedirect). This way, the extension author has much more power over the actual final URL and can then decide if she/he needs to re-create/modify or just leave the URL?
  3. Stefan Bürk commented on patch set 19 03/27/23, 08:30

    Reply

    I added this event based on a user request (longer talk, screenshare). Currently, the they xclass RedirectService to manipulate settings for the generation exactly on that place. So I would say, it's not completly useless. As this event with others helps them to avoid xclassing I would go forward to add this event anyway. We can considier to add an additional event in the end then, but I guess I would not find the time to finish the other event in time before freeze release.
  4. Stefan Bürk wrote 03/27/23, 08:30

    Removed cc Andri Steiner.
  5. Stefan Bürk commented on patch set 20 V +1 03/27/23, 08:35

    Published edit on patch set 19.
  6. Stefan Bürk rebased onto patch set 21 03/27/23, 08:36

  7. core-ci voted on patch set 20 V +1 03/27/23, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39673

  8. core-ci voted on patch set 21 V +1 03/27/23, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39674

  9. Simon Schaufelberger uploaded patch set 22 V +1 08/24/23, 14:47

  10. core-ci voted on patch set 22 V -1 08/24/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45787

  11. Simon Schaufelberger uploaded patch set 23 V -1 08/24/23, 14:57

  12. core-ci voted on patch set 23 V +1 08/24/23, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45788

  13. Jörg Bösche voted on patch set 23 CR +1 08/25/23, 13:49

  14. Stefan Bürk uploaded patch set 24 CR +1 V +1 09/27/23, 14:57

  15. Stefan Bürk updated the commit message in patch set 25 09/27/23, 14:59

  16. Stefan Bürk uploaded patch set 26 09/27/23, 15:01

  17. core-ci voted on patch set 24 V +1 09/27/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47249

  18. core-ci voted on patch set 25 V +1 09/27/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47250

  19. core-ci voted on patch set 26 V +1 09/27/23, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47251

  20. Sybille Peters wrote 10/27/23, 06:14

    Removed reviewer Sybille Peters.
  21. Stefan Bürk rebased onto patch set 27 V +1 11/29/23, 08:48

  22. core-ci voted on patch set 27 V -1 11/29/23, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50095

  23. Benni Mack wrote 01/30/24, 14:28

    Removed reviewer Benni Mack.
  24. Benni Mack wrote 03/22/25, 16:41

    Topic set to redirects
  25. Benni Mack marked it work in progress 03/28/25, 13:52